Repository navigation
Sync main into prerelease/2.2 - #324
Merged
Merged
Conversation
- Threshold services resolve an entity against the monitor's stored overrides as well as the live circuits, so the override of a circuit that has left the panel can still be cleared through its orphaned entity. Only this integration's entities are matched. - A hardware status that cannot be read proceeds without clearing a standing unvalidated-hardware Repair; httpx.InvalidURL is caught too. - The hardware verdict ignores surrounding whitespace and the case of UNKNOWN, so a spelling alone cannot make the terminal refusal. - A threshold call whose entity's own panel is not loaded says so instead of reporting monitoring as disabled. - Correct the battery power docstring: an unpublished value now reads unknown where 2.0.8 reported 0 W. - Circuit sensor name fallbacks use construct_circuit_identifier_from_tabs.
fix: address review findings on the 2.1.3b2 changes
Brings #322's review fixes onto the 2.2 line. Resolutions: 2.2 reads the hardware version in hardware_guard.async_read_hardware_version, shared by setup and credential rotation, so #322's unread-status change is ported there instead of keeping a second read in __init__.py: the read answers HARDWARE_UNREAD on failure and also catches httpx.InvalidURL, setup leaves a standing unvalidated-hardware Repair up on an unread status, and rotation treats it as unknown hardware as before. The verdict test table keeps both sides' cases, 3.0 and the whitespace and case variants. This also puts the read timeout's docstring back under its constant.
No AI attribution in history or on GitHub
Brings #323's no-AI-attribution rule in AGENTS.md onto the 2.2 line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #322's review fixes onto the 2.2 line, as one merge commit. 2.2 reads the hardware version in
hardware_guard.async_read_hardware_version, shared by setup and credential rotation, so #322's unread-status change is ported there rather than kept as a second read: the read answersHARDWARE_UNREADon failure and catcheshttpx.InvalidURL, setup leaves a standing unvalidated-hardware Repair up on an unread status, and rotation treats it as unknown hardware as before. The verdict test table keeps both sides' cases. pytest: 2454 passed, 1 skipped; all pre-commit hooks pass.