Add number of sides and side selection#70
Merged
Merged
Conversation
…ry into update-versions
h-mayorquin
approved these changes
Jul 15, 2026
h-mayorquin
left a comment
h-mayorquin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, this is basically the menu-side work that #66 did, right?
Member
Author
|
yes indeed! I'll merge so you can take a look :) |
Collaborator
I already built it locally and take a look. Feel free to merge. I spotted other errors (that I introduced) so I will make a PR soon. |
Collaborator
|
Actually, let's merge so I can work with the changes that you did and include them in teh fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only for manufacturers with 1/2 sides probes