Conversation
Contributor
Author
|
hi. @SebastianStehle |
Contributor
|
I think we have to check out the indexes and see if they match with the queries. Just having an additional index is not necessarily the best idea |
Contributor
Author
I agree. |
Contributor
|
I have pushed a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1344
What
Adds an index
{ _ai: 1, pi: 1, mt: -1, id: 1 }toStates_Assets2.Why
The assets query filters by app and parent folder and sorts by
mt desc, id asc. The existing index starts withmt, so MongoDB walks the index inmtorder across the whole collection and filters afterwards. With a large collection this makes root folder queries and their total count very slow, and they hitassets.timeoutQuery(408).The new index starts with the equality fields (
_ai,pi) and then follows the sort order, so the query and the count only read the requested folder.