Skip to content

Add Player Count - #205

Open
swindlesmccoop wants to merge 1 commit into
SteamClientHomebrew:mainfrom
swindlesmccoop:add-playercount-badge
Open

Add Player Count#205
swindlesmccoop wants to merge 1 commit into
SteamClientHomebrew:mainfrom
swindlesmccoop:add-playercount-badge

Conversation

@swindlesmccoop

Copy link
Copy Markdown

No description provided.

@BlythT

BlythT commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

FYI You may want to fill out the template from https://github.com/SteamClientHomebrew/PluginDatabase/blob/main/.github/PULL_REQUEST_TEMPLATE/PLUGIN-SUBMISSION.md

And there is a similar plugin to this: #151 but neither that or yours have been merged (potentially for not using the template? Unsure)

@BlythT

BlythT commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Tested and working though :)

image

@swindlesmccoop

Copy link
Copy Markdown
Author

FYI You may want to fill out the template from https://github.com/SteamClientHomebrew/PluginDatabase/blob/main/.github/PULL_REQUEST_TEMPLATE/PLUGIN-SUBMISSION.md

And there is a similar plugin to this: #151 but neither that or yours have been merged (potentially for not using the template? Unsure)

Quite frankly I didn't see this nor was there a prompt to use it when I created the pull request; this should be more clear. I'll take a look at updating it and following the rest of the guidelines tomorrow.

@BlythT

BlythT commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

FYI You may want to fill out the template from https://github.com/SteamClientHomebrew/PluginDatabase/blob/main/.github/PULL_REQUEST_TEMPLATE/PLUGIN-SUBMISSION.md
And there is a similar plugin to this: #151 but neither that or yours have been merged (potentially for not using the template? Unsure)

Quite frankly I didn't see this nor was there a prompt to use it when I created the pull request; this should be more clear. I'll take a look at updating it and following the rest of the guidelines tomorrow.

Agreed, was just a friendly hint. I'll take a look at why it's not the default / suggested template when creating a PR against this repo.

@BlythT

BlythT commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Suggested that here #210

@github-actions github-actions Bot changed the title Add player count badge to game page on library Add Player Count Jul 29, 2026
@shdwmtr
shdwmtr requested a review from Copilot July 30, 2026 00:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants