Skip to content

noexcept for some methods of abstract_message_box_t #89

Description

@eao197

There are two methods of abstract_message_box_t that are not marked as noexcept: id() and type().

I don't remember why they do not have noexcept specifier and don't see any reasons why they are not noexcept. It seems to me that they can be used in noexcept contexts.

And it's hard to imagine an implementation of such methods that throws.

May be they have to be marked as noexcept?

If it has a sense then such a change can be made in v.5.9 to avoid breaking compatibility of abstract_message_box_t interface in 5.8-branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions