Skip to content

Add accessible names to single place map pins - #302

Merged
yakew7 merged 2 commits into
StudentSuite:mainfrom
jay23606:pr-go/296-single-map-pins-have-no-accessible-name-
Oct 23, 2026
Merged

yakew7 merged 2 commits into
StudentSuite:mainfrom
jay23606:pr-go/296-single-map-pins-have-no-accessible-name-

Conversation

@jay23606

Copy link
Copy Markdown
Contributor

Bug

Single place map pins were focusable controls without an accessible name.

Change

Set each single pin's Leaflet title to its place name and category.

Testing

  • npx vitest run src/components/map/map-view.test.tsx

Regression test: fails on base twice (/Unable to find an accessible element with the role "button" and name /Heathrow Airport, Airport//), passes on fix twice (npx vitest run src/components/map/map-view.test.tsx)

Fixes #296

@jay23606

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

@jay23606 is attempting to deploy a commit to the studentsuite Team on Vercel.

A member of the Team first needs to authorize it.

@AnayDhawan

Copy link
Copy Markdown
Member

Hi,
Please fix your lint & typecheck error, then we shall accept your PR.

@propcgamer20-png

propcgamer20-png commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

heyy Thanks for the pr. The lint-typecheck check is failing on the Prettier format step, and only one file is flagged: src/components/map/map-view.test.tsx. Everything else (build, unit tests, data validation) passes.

To fix it, run this from the repo root and push the result:

npx prettier --write src/components/map/map-view.test.tsx

Then npm run format:check should pass, and the check will pass on the re-run. If the Vercel check also shows as failed, that one only needs a team member to authorize the deploy and is not caused by your change.

Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@yakew7
yakew7 merged commit befcc8f into StudentSuite:main Oct 23, 2026
4 of 5 checks passed
@jay23606
jay23606 deleted the pr-go/296-single-map-pins-have-no-accessible-name- branch October 23, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single map pins have no accessible name for screen readers

4 participants