Repository navigation
fix(search): match places regardless of accents - #303
Merged
Merged
Conversation
Contributor
|
@uzumakienes is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Closes #291. Adds
foldText()tosrc/lib/utils.ts(NFD, strip combining marks, lower-case, plusł,ø,đ,ı) and uses it on both the query and the place name infilterPlacesand insearchSite, soesenboga,krakowandfrancaisefind Esenboğa, Kraków and Française, and accented queries still match. Tests added forfoldText, the map search and the nav search.The combining marks are stripped with
[\u0300-\u036f]rather than\p{M}, becausetsconfig.jsontargets ES2017.Type of change
Checklist
AI disclosure: this change was prepared with Claude Code. The test suite was not run locally; the folding function was checked separately against the examples in the issue.
🤖 Generated with Claude Code
https://claude.ai/code/session_013HYYsiY4FhVN7hNWkVRoSK