Repository navigation
fix(map): preserve search queries in shared URLs - #304
Merged
Merged
Conversation
Contributor
|
@KingEmma7 is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Keep
qin the map URL and Share link, using the same debounced query as the displayed results. Opening/map?q=library, editing the search, and reloading a shared link now preserve the search alongside the existing filters, focused place, and viewport.Fixes #289.
Type of change
Proof (required for new public places)
Not applicable; no place data changed.
Validation
npm run lint,npx tsc --noEmit,npm run format:check,npm run validate, andnpm run buildpassed.npm run test:unit: 578 tests passed. Added query round-trip and component regressions that fail on the original behavior.No MapTiler key was configured, so map tiles and panning were not tested. The existing server/client result-count hydration warning also occurs on the unchanged base.
Checklist