Reorganize project structure, packaging, and CI - #8
Suhaibinator wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70eea7c8cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| t.messagesChannel <- data | ||
| result := <-t.resultChannel |
There was a problem hiding this comment.
Pair each insert result with its producer
When concurrent Produce RPCs target the same topic, each caller sends through messagesChannel but then reads from the same shared resultChannel. If the worker accepts the second message before the first caller receives its result, the second caller can consume the first insert's addResult, causing acknowledgements to return another producer's offset. Use a per-request response channel or otherwise serialize each send/result pair.
Useful? React with 👍 / 👎.
Summary
srclayout with deterministic generated bindings, corrected streaming behavior, tested packaging, and independent release versioningCompatibility
smqprotobuf wire package and field numbers are unchangedgithub.com/Suhaibinator/SuhaibMessageQueue/protoremains available through deprecated aliasesvX.Y.Z; Python releases usepysmq-vX.Y.ZValidation
go vet ./...go test -race -shuffle=on ./...go build -trimpath ./cmd/smqtwine check