Skip to content

Remove the homepage hero eyebrow rule #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeylong merged 1 commit into from
Oct 17, 2026
Merged

Remove the homepage hero eyebrow rule #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/surfaces-web/app/homepage.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,6 @@ body.menu-open {
}

.surfaces-homepage .hero .eyebrow {
padding-left: 10px;
border-left: 2px solid var(--sp-ui-proof);
color: var(--sp-color-mist);
text-transform: uppercase;
}
Expand Down
11 changes: 7 additions & 4 deletions apps/surfaces-web/tests/home-page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ describe("surfaces.systems home page", () => {
expect(homepageCss).toMatch(
/\.surfaces-homepage \.hero \.eyebrow\s*\{[^}]*color:\s*var\(--sp-color-mist\);/,
);
expect(homepageCss).toMatch(
/\.surfaces-homepage \.hero \.eyebrow\s*\{[^}]*border-left:\s*2px solid var\(--sp-ui-proof\);/,
);
const heroEyebrowCss = homepageCss.match(
/\.surfaces-homepage \.hero \.eyebrow\s*\{([^}]*)\}/,
)?.[1];
expect(heroEyebrowCss).toBeDefined();
expect(heroEyebrowCss).not.toMatch(/border(?:-left|-inline-start)?:/);
expect(heroEyebrowCss).not.toMatch(/padding(?:-left|-inline-start)?:/);
const heroLead = page.querySelector(".hero-lead")?.textContent?.replace(/\s+/g, " ").trim();
expect(heroLead).toBe(
"Resolve clear, repeated violations sooner, so senior judgment stays focused on what’s genuinely new or contested.",
Expand Down Expand Up @@ -121,7 +124,7 @@ describe("surfaces.systems home page", () => {
expect(page.querySelectorAll(".proof-section")).toHaveLength(0);
expect(page.querySelectorAll(".partner-section")).toHaveLength(0);
expect(sha256(homepageCss)).toBe(
"22c4ca0f31cfb45201e8cf2b564e8380faf7dc269cd4ba7dd71fc53298512b0f",
"92f2190a4022332e92004af576c784543af09c85519015281e9dfb61fd931789",
);
expect(sha256(slabAsset)).toBe(
"8901f5ad73c5a96aeb10647e98fc9e9f6151bf55152911e948e3be0343e3a64f",
Expand Down
Loading