Skip to content

[codex] Fix Android code scanning alerts - #3

Merged
66Ton99 merged 1 commit into
mainfrom
codex/fix-code-scanning-alerts
Jun 6, 2026
Merged

66Ton99 merged 1 commit into
mainfrom
codex/fix-code-scanning-alerts

Conversation

@66Ton99

@66Ton99 66Ton99 commented Jun 6, 2026

Copy link
Copy Markdown

Summary

  • fix the explicit clipboard clear PendingIntent used by AlarmManager
  • migrate biometric passphrase encryption from AES/CBC/PKCS7Padding to AES/GCM/NoPadding
  • remove incompatible legacy biometric keys on cipher init failure so users can re-enable biometrics with a GCM key
  • bump the visible Android version to 3.0.15 and clean two import-order violations in the touched accounts module

Root cause

CodeQL reported two high-severity alerts on main: an implicit PendingIntent in clipboard clearing and CBC/PKCS7 biometric encryption. The biometric key spec still generated CBC keys, so the cipher and keystore parameters both needed to move to GCM.

Validation

  • ./gradlew assembleDebug
  • ./gradlew unitTest coverageReport lintDebug
  • ./gradlew :accounts:ktlintCheck 📋ktlintCheck :encryptedstorage:ktlintCheck

Note: the broad local detekt task currently fails on pre-existing InvalidPackageDeclaration findings from the package rename, and is not part of the current GitHub Actions checks.

@66Ton99
66Ton99 force-pushed the codex/fix-code-scanning-alerts branch from f8b2792 to 7bedb8c Compare June 6, 2026 21:34
@66Ton99
66Ton99 marked this pull request as ready for review June 6, 2026 21:44
@66Ton99
66Ton99 merged commit a4a65b7 into main Jun 6, 2026
5 checks passed
@66Ton99
66Ton99 deleted the codex/fix-code-scanning-alerts branch June 6, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant