Repository navigation
Menorah: modello nuovo con candele accese per sera - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rifatto il modello del candelabro (menorah), come richiesto.
Modello
candles=0: 9 candele spente con lo stoppino.candles=N(1-8): shamash e N candele accese, da destra guardando il lato sud. Le fiamme hannolight_emission15.candles(menorah.json+menorah_lit_1..8.json), generati dascripts/models/gen_menorah.py.Codice
MenorahBlock: contorno e collisione ora seguono il modello (base, bracci, shamash); le particelle escono dalle fiamme vere.candlesinvariati: mondi esistenti, strutture e decorazioni di Hanukkah nello Shuk (PR Grand Market: decorazioni temporanee delle feste sui banconi #79) restano compatibili.Verifica
Solo validazione JSON/UV con Python e la CI. Nessun test in gioco, su richiesta.