Type Parameter Modernization - #202
Draft
FrancescoPezzella wants to merge 78 commits into
Draft
FrancescoPezzella wants to merge 78 commits into
FrancescoPezzella wants to merge 78 commits into
Conversation
Collaborator
Author
|
Goal of this new PR:
In this way, I have managed to get rid of all the unnecessary clutter in Git History and also follow the workflow I saw other PRs follow. |
FrancescoPezzella
added this pull request to stack #203
September 21, 2026 12:52
Collaborator
Author
|
I am gonna try out this whole stacked thing, so my changes dont get blocked by some feature I could use. |
Closed
FrancescoPezzella
force-pushed
the
typing-recipes-2
branch
from
September 21, 2026 15:27
837a32c to
e392a36
Compare
FrancescoPezzella
force-pushed
the
typing-recipes-2
branch
from
September 23, 2026 07:55
e4ab32d to
ff4016f
Compare
FrancescoPezzella
force-pushed
the
typing-recipes-2
branch
3 times, most recently
from
September 30, 2026 11:56
eaeef61 to
f5168f2
Compare
… Added more tests for all of the cases.
…ould be without touching any outside code
…orrectly split - adjusted the files to correctly fit the new convention. Added new hypothesis testing to test_type_var_check_properties.py that forces at least 1 case TypeVar.
…le usage in a single pass: localizes cross-file imports, converts every declared type parameter to PEP 695 syntax regardless of scope, and cleans up declarations left orphaned by ruff or manual conversion. Added the Recipes and Type parameter scope documentation pages, plus tests covering all three phases.
… collapsing isinstance narrowing to Never) by annotating it as object | None - verified with zero new pyright errors across src/ and no test regressions. Added the python-ast-known-limitations.md page documenting the remaining known gaps in the Python AST/RST layer found while building TypeVarCheck, and marked it done in docs/TODO.
…agraph and list-item lines to the project's 140-char limit, moved the anchor after the top-level heading in python-ast-known-limitations.md, and fixed a nested-list indent in core.md. No content changes, only wrapping/formatting.
…runs on 3.12+ targets, verified live against sqlalchemy), fixed two real bugs found in that testing (missing Or/MatMult in KIND_MAP, and the shared rewrite pipeline double-indenting multi-line docstrings), and cleaned up overly verbose comments and redundant tests.
…en an ast list field holds a bare None (e.g. a keyword-only arg with no default in ast.arguments.kw_defaults)
…odel and safety analysis, shared with TypeVarTupleCheck instead of importing from another recipe's file) and utils/unparse_utils.py (the shared ast.unparse() docstring-indent workaround) out of type_var_check.py, and added find_rst_node/remove_import_alias as generic helpers on the PythonRefactoring base class so future recipes get them for free. type_var_check.py itself shrinks to pipeline orchestration only. Renamed five domain functions that were named as module-private (leading underscore) despite being genuinely used cross-file, matching pyright strict's reportPrivateUsage/reportUnusedFunction. Split test_type_var_check.py by phase into test_type_var_check_convert.py, test_type_var_check_localize.py, test_type_var_check_orphaned.py, plus a shared conftest.py fixture replacing three near-duplicate private test helpers, and added direct tests for the two new base-class methods. Reworded every docstring across the five touched files to satisfy ruff's full intended ruleset (E, F, W, I, N, B, D, UP, TD), not just the project's current E-only baseline - verified with pyright strict via a temporary per-file marker (never committed). Updated recipes.md, typevar-modernization.md and python-ast-known-limitations.md to match.
…ain.py that were actually ours to fix: added type_param_name() to narrow ast.type_param to its concrete subclasses (TypeVar/ParamSpec/TypeVarTuple), which lack a shared .name in the typeshed stubs, and removed 3 redundant casts now that PythonRstNode.node is already typed as ast.AST. Verified with ruff's full ruleset, the project's real pyright/ruff settings, and the full test suite.
…riter.py), work around it in TypeVarCheck, and document the fallout. _RewriteActions.apply() now raises instead of silently concatenating two edits queued against overlapping source ranges, matching the pre-existing "Error cases" spec in features/rewrite-semantics.feature and un-xfailing test_replacing_same_node_twice_always_errors. TypeVarCheck avoids ever triggering it: PythonRefactoring.remove_import_alias() batches multiple names sharing one import into a single edit, and convert_declared_typevars does one replace() per function instead of one per type param. Added a regression test covering two type params sharing one import. The same fix also revealed a pre-existing instance of the bug in Taut2Pyunit, marked xfail(strict=True) and left unfixed. Documented as item 5 in python-ast-known-limitations.md.
…riter.py), work around it in TypeVarCheck, and document the fallout.
Resolves from-imports across the whole target codebase (not just __all__) before localizing/removing a TypeVar declaration, via the new import_resolution.py utility. Utilize the new PythonScanner function
…ible to bugs and unintended effects. User must now specify the Python version for which they would like to convert their project. This removes a lot of code, and overall simplifies the tool. This is a choice to not go overboard with implementations and not add things that already exist or can be solved in an easier way.
… default), this makes the test not replicate the real application (where UTF-8 is not always forced, yet)
…is gives the user a bit more control over the tool, allowing them to use what they wish, without being overly confusing.
FrancescoPezzella
force-pushed
the
typing-recipes-2
branch
from
October 2, 2026 14:35
b7ed437 to
6120c5c
Compare
Collaborator
Author
|
Names such as Type Hints and Type Var were rejected, such as Type Hints being too broad and covering list[int] etc which other tools such as Ruff already do, while Type Var being imprecise and not covering all the changes made here such as ParamSpec and TypeVarTuple (which are not technically Type Vars). I will from now on be referring to this as Type Parameter Modernization. |
…ng time; EXCLUDED_DIRS was ignoring any path with an excluded keyword, even if it was outside of project, for example: C:/venv/project_name/file_name This would cause every file in the project to be ignored, which is not intended behavior
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about modernizing Type Parameters.