CI/CD now covers ./features, made func less strict, adjusted/fixed tests - #219
Conversation
|
The tests started failing when the proper detection was added by #177 |
|
@pjljvandelaar Can I get more specification from you whether my change is in the right direction or not? 0d33c25 In this commit, when I made the duplicate rewriter detection system, it turned out to be too strict. I could have made the tests failing, but is no reason, since duplicates rewrites (something I believe Corvino mention during your brief discussion) are not always an issue. So the function is less strict now. |
5d2c294 to
8940caf
Compare
FrancescoPezzella
changed the title
Automatic Python lint fixes Pipeline should now properly fail
…OVE/REPLACE condition needs this check. For other conditions, it does not need to be so strict. This causes most of the tests to work again, since they do not have to follow such strict requirements.
…een failing, update xfail descriptions
8940caf to
0de6f7b
Compare
pjljvandelaar
left a comment
pjljvandelaar
left a comment
There was a problem hiding this comment.
Do you agree that we should accept it now, and later on change it again once the new structure is made effective?
I believe it should be accepted now. The architectural change is a separate issue, and the only thing that will change is that Ci/Cd no longer needs to cover ./features. All the other changes would stay more or less the same, so I don't really see a reason for it not be accepted separately. |
2 participants
Fixes #218