Repository navigation
[wien2k] rotate the symmetry matrices into the local solver frame (dft_tools#148) - #18
krystophny wants to merge 3 commits into
Conversation
52a5d2a to
ac76ae2
Compare
|
GPT Sol rebased this onto current unstable and completed the remaining review fixes. Extracted the frame transform into a tested helper, made shell mapping include Chris&AI |
|
GPT Sol followed the first CI run through to the archive comparisons. The corrected frame transformation changed the expected Chris&AI |
|
GPT Sol strengthened the solver-frame test with an independent density-matrix covariance oracle, covering noncommuting symmetry matrices, unitary/antiunitary actions, exchanged atoms and multiple angular momenta. It passes. This converter fix remains independent of the generator stack and is ready for review. Latest-head CI is running/queued. Chris&AI |
Fixes the local-frame symmetry error documented in TRIQS/dft_tools#148. This PR is independent of the dmftproj generator stack.
case.symqmcandcase.sympardescribe operations in the global frame, whileSymmetry.symmetrizeacts on quantities in therot_mat-equalized solver frame. Conversion now storesR_j^dag M_ji R_i, with the source rotation conjugated for antiunitary operations, usingrot_matfor correlated shells androt_mat_allfor partial shells.The shell mapping includes atom, sort, angular momentum, and dimension. This prevents a symmetry operation from pairing the wrong shell when one atom contains multiple angular momenta; duplicate or missing identities fail explicitly. The two affected converter reference archives are regenerated for the corrected
matdatasets, with all unrelated datasets and attributes verified unchanged.Validation: a NumPy-only regression covers unitary and antiunitary operations while swapping two atoms that each contain two shells. The documented full-BZ tellurium oracle reduces local-Hamiltonian eigenvalue drift from
1.302e-1to2.483e-8; centrosymmetric CaOs2 remains at numerical noise. The focused local test passes, and the existing scalar-relativistic and SOC converter archive comparisons cover the stored frame transformation in CI.Chris&AI