Skip to content

esp-idf 6.1 fixes - #47

Merged
KenVanHoeylandt merged 6 commits into
mainfrom
esp-idf-6.1-fixes
Sep 14, 2026
Merged

KenVanHoeylandt merged 6 commits into
mainfrom
esp-idf-6.1-fixes

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Release Updates

    • Updated app versions and build numbers for Brainfuck, Breakout, Calculator, CoreUtils, Diceware, Doom, EpubReader, ESP-NOW Bridge, GPIO, GraphicsDemo, HelloWorld, M5 Unit Test, Magic 8-Ball, Media Keys, MystifyDemo, Serial Console, Snake, TamaTac, TodoList, and TwoEleven.
  • Bug Fixes

    • Improved Doom compatibility with newer C23 builds.
    • Improved Doom rendering configuration and audio integration for more reliable operation.
    • Improved GPIO pin monitoring with clearer status indicators and more reliable timer and device handling.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a23e8b6f-824b-40bd-8f97-9ce50cfefd8d

📥 Commits

Reviewing files that changed from the base of the PR and between 1acb45b and 5ebb9c0.

📒 Files selected for processing (5)
  • Apps/Doom/main/doomgeneric/doomgeneric/r_things.c
  • Apps/GPIO/main/CMakeLists.txt
  • Apps/GPIO/main/Source/Gpio.cpp
  • Apps/GPIO/main/Source/Gpio.h
  • Apps/GPIO/main/Source/main.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates Doom for C23 boolean handling, preserves the sprite rotation sentinel state, and expands PPA operation and client configuration. It adds explicit GPIO controller and C timer handling with runtime-sized state arrays and updated indicators. The build action now uses ESP-IDF v6.1, Diceware constants use static constexpr auto*, and 20 application manifests receive version increments.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 5ebb9

No merge-blocking defect is established by the available evidence.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 23.08% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 9 files. (1 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main purpose of the changes: ESP-IDF 6.1 compatibility fixes. The changes include pinning the build action to ESP-IDF 6.1 and updating affected application code.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 23.08% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 9 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch esp-idf-6.1-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 742e7565-6df1-4b7c-a912-a9d424ee9fca

📥 Commits

Reviewing files that changed from the base of the PR and between bf6c1c3 and 33fa283.

📒 Files selected for processing (24)
  • Apps/Brainfuck/manifest.properties
  • Apps/Breakout/manifest.properties
  • Apps/Calculator/manifest.properties
  • Apps/CoreUtils/manifest.properties
  • Apps/Diceware/manifest.properties
  • Apps/Doom/main/Source/DoomAudio.cpp
  • Apps/Doom/main/Source/DoomEsp.cpp
  • Apps/Doom/main/doomgeneric/doomgeneric/doomtype.h
  • Apps/Doom/main/doomgeneric/doomgeneric/r_defs.h
  • Apps/Doom/manifest.properties
  • Apps/EpubReader/manifest.properties
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/manifest.properties
  • Apps/GraphicsDemo/manifest.properties
  • Apps/HelloWorld/manifest.properties
  • Apps/M5UnitTest/manifest.properties
  • Apps/Magic8Ball/manifest.properties
  • Apps/MediaKeys/manifest.properties
  • Apps/MystifyDemo/manifest.properties
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/manifest.properties
  • Apps/TodoList/manifest.properties
  • Apps/TwoEleven/manifest.properties

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread Apps/Doom/main/doomgeneric/doomgeneric/r_defs.h
@KenVanHoeylandt
KenVanHoeylandt merged commit 085c5db into main Sep 14, 2026
24 of 43 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the esp-idf-6.1-fixes branch September 14, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant