Conversation
7 tasks done
7 tasks done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to merged #970. Legacy sessions split across scopes use their already-reported credit in previews. Missing baseline snapshots reuse the same owners without seeding the disk file. Only the stats/recall guard rows move; #971 rows remain unchanged.
Type of Change
Test Plan
session-owners.jsonlduring preview.npm run build,npx tsc --noEmit,npm run lintpass.npx vitest run: 8015 passed, 20 skipped. Relevant built-CLI E2E: 31 passed across stats/recall, refusal, dashboard, report scope reuse and recall maintenance votes.python3 /tmp/teamai-900/C-sol-round3-realcli.py "$PWD/dist/index.js"passed. Stats preview and real stats both show 1 session / 6 turns. Recall preview returnsDeployment timeout fix. Full fixture SHA256 stays9acfcb0ee2f22beaaacb01ee6bedf19e2ccda204a53dae2aa0a99ad13cac8c54across both previews, 121 files. Owners/index/sessions remain absent; config bytes remain identical after real stats too. Real stats still seeds owners and prints no dry-run notice; explicit preview retains its migration notice.Related Issues
Refs #900 (C6, C9 followup)
Refs #972
Merge Danger
Door: two-way
Blast Radius: stats
No storage format change or global cache. Real stats retains ordinary owner seeding. Reporting callers retain disk-backed defaults.
Notes for Reviewers
Addresses the remaining #970 review and its merge integration defect. The new state lives in one stats invocation; scope filtering and baseline/credit reads consume it. The reports checkout remains unrefreshed during preview, so totals can still differ from real stats when remote reports changed.
Updated both usage guides. No affected refusal wording exists in skill-data or designs; help and command-reference generation are unchanged. Whole branch diff and shared-state readers/writers are documented in
/tmp/teamai-900/C-sol-round3-result.md.