Skip to content

reorganise workflow - #295

Open
tomjemmett wants to merge 3 commits into
move_pop_extract_to_inputsfrom
alter_main_workflow
Open

tomjemmett wants to merge 3 commits into
move_pop_extract_to_inputsfrom
alter_main_workflow

Conversation

@tomjemmett

@tomjemmett tomjemmett commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

limitations in udal prevent the current compute clusters from having more than two workflows running at once.

run the op after the a&e data, as these together take roughly same time
as ip data.

also run the inputs/tpma explorer for provider/local authorities in parallel


Stack created with GitHub Stacks CLI • Give Feedback 💬

@tomjemmett
tomjemmett added this pull request to stack #294 October 13, 2026 19:18
@tomjemmett
tomjemmett marked this pull request as ready for review October 19, 2026 10:27
@tomjemmett
tomjemmett requested a review from a team as a code owner October 19, 2026 10:27
Copilot AI balanced review requested due to automatic review settings October 19, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The resulting DAG serialises IP after A&E, which appears to diverge from the description's stated parallelisation goal, and confirming the intended production scheduling requires domain knowledge of job runtimes.

1 open issue
What changed in this PR

This PR reorganises the Generate NHP Data Databricks workflow DAG to work around a UDAL constraint that allows at most two child workflows to run concurrently on the current compute cluster. It reshapes the task dependencies so A&E (ECDS) runs before IP/OP, runs the provider and local-authority inputs jobs in parallel, and chains the container extract job onto the end of the pipeline.

Changes:

  • generate_ip and generate_op now depend on generate_ecds instead of generate_nhp_reference_data.
  • generate_inputs_data_local_authorities now depends on generate_ip/generate_op (instead of generate_inputs_data_provider), so provider and LA inputs run in parallel; the redundant generate_ecds dependency was dropped from the provider inputs task.
  • Added a new extract_data task (Extract_NHP_for_containers) that runs after both inputs jobs complete.
File Description
databricks_workflows/​nhp_data.yaml Re-wires the task dependency graph to cap concurrency at two workflows, parallelises the inputs jobs, and appends the container extract job.

Review effort: Balanced

Comment thread databricks_workflows/nhp_data.yaml Outdated
tomjemmett and others added 2 commits October 19, 2026 11:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated docstring to clarify the purpose of the main function and the tables generated.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@tomjemmett
tomjemmett force-pushed the alter_main_workflow branch 5 times, most recently from 3f023e9 to d05df85 Compare October 21, 2026 14:21
limitations in udal prevent the current compute clusters from having more than two workflows running at once.

run the op after the a&e data, as these together take roughly same time
as ip data.

also run the inputs/tpma explorer for provider/local authorities in parallel

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants