Repository navigation
switch all selectInputs to selectizeInputs - #32
Conversation
c3d5069 to
8b889ea
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The UI currently passes an invalid selectize argument to selectizeInput() (runtime error) and one newly-converted selectize control lacks the established dropdownParent="body" option used to prevent clipping.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR continues the UI refactor started in #22 by converting remaining shiny::selectInput() controls to shiny::selectizeInput() and aligning server-side updates accordingly, primarily to avoid dropdown menus being clipped inside card/collapse containers (issue #21).
Changes:
- Converted several UI dropdowns in
R/app_ui.RfromselectInputtoselectizeInput, addingoptions = list(dropdownParent = "body")in most cases. - Updated corresponding server logic in
R/app_server.RfromupdateSelectInput()toupdateSelectizeInput()for the migrated inputs.
File summaries
| File | Description |
|---|---|
| R/app_ui.R | Migrates UI dropdown inputs to selectizeInput and sets selectize dropdown rendering options to reduce overflow clipping. |
| R/app_server.R | Migrates server-side dropdown updates to updateSelectizeInput to match the new UI input types. |
Review details
Suppressed comments (1)
R/app_ui.R:160
- This newly converted
previous_scenariocontrol is aselectizeInput, but unlike the other selectize inputs in cards/collapses it does not setoptions = list(dropdownParent = "body"). Without this, the dropdown can be clipped by the surrounding card/collapse overflow when the input is shown.
shiny::selectizeInput(
"previous_scenario",
"Previous Scenario",
NULL,
width = "100%"
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Lextuga007
left a comment
There was a problem hiding this comment.
Runs ok locally but I'd only checked the first two year drop downs before. This time I've been unable to get beyond setting up a test Scenario. Code looks ok though.
related to #22, copilot didn't find all cases that needed to be updated
closes #21