Repository navigation
Improve scenario name UI - #36
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It introduces a new undeclared {withr} dependency in server logic and uses a likely-unsupported bslib theme variable, both of which risk the intended behavior not working in deployment.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates the “Scenario name” UX to reduce confusion around unavailable scenario actions and to improve validation/guidance presentation in the Shiny UI.
Changes:
- Only presents scenario-type radio options when they’re actually available (instead of disabling them).
- Reorders the “Start” button vs naming guidance content and aligns the button without extra UI wrapper markup.
- Attempts to theme validation message color via bslib theme variables.
File summaries
| File | Description |
|---|---|
| R/app_ui.R | Simplifies scenario-type radios, reorders start button vs naming guidance, and adds a theme variable intended to make validation messages red. |
| R/app_server.R | Adjusts validation-side show/hide behavior for naming guidance and updates radio choices dynamically based on whether saved scenarios exist. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I like this approach, thank you. Only change is that the text colour as we still need to avoid red but the use of symbols like the triangle with exclamation with text, perhaps bold, would be more accessible. |
|
you are somewhat limited to what you can achieve with shiny validation though, at least you may have to spend a lot of time unpicking the classes and figuring out what to change. shiny validation does append |
Lextuga007
left a comment
There was a problem hiding this comment.
Works ok locally and did a build check all passes. Thanks for looking into ways of supporting the text using CSS, much appreciated.

resolves #33