Repository navigation
adds carto api key to deploy action - #37
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workflow now deploys a key that the app exposes to browsers (client-side window.CARTO_API_KEY usage), so token sensitivity/scoping should be corrected or explicitly validated before merging.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates the manual Connect publish GitHub Actions workflow to provide a Carto API key to the deployed Connect application via an environment variable, enabling the app’s map tile layer to authenticate against Carto.
Changes:
- Add
CONNECT_ENV_SET_CARTO_API_KEYto the Connect publish step soCARTO_API_KEYis set on the deployed content.
File summaries
| File | Description |
|---|---|
.github/workflows/connect-publish-manual.yaml |
Passes CARTO_API_KEY into the Connect deployment environment via CONNECT_ENV_SET_*. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
the carto key needs to be injected into the browser, so this is fine. |
matt-dray
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.