Skip to content

fix(split): support multi-character separators - #14685

Merged
cclauss merged 1 commit into
TheAlgorithms:masterfrom
MD-Mushfiqur123:fix/split-multi-char-separator
Sep 9, 2026
Merged

fix(split): support multi-character separators#14685
cclauss merged 1 commit into
TheAlgorithms:masterfrom
MD-Mushfiqur123:fix/split-multi-char-separator

Conversation

@MD-Mushfiqur123

@MD-Mushfiqur123 MD-Mushfiqur123 commented May 16, 2026

Copy link
Copy Markdown
Contributor

Describe your change:

Fixes #14649
Fixes #14721
Fixes #14751
Fixes #15046
Fixes #15242

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

The custom split function in strings/split.py compares each character in the input string against the full separator string, which means multi-character separators such as "--" are never matched and the string is returned unsplit.

Fix

Replace character-by-character iteration with substring matching at each position, comparing string[index:index + separator_length] against the separator. This correctly handles separators of any length.

Testing

  • All existing doctests pass
  • Added doctests for multi-character separators: "--" and "##"

Fixes #14649

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 16, 2026
@cclauss

cclauss commented Sep 9, 2026

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

Signed-off-by: god032396-del <god032396@gmail.com>
@cclauss
cclauss force-pushed the fix/split-multi-char-separator branch from 0323028 to 15af0e7 Compare September 9, 2026 18:05
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 9, 2026
@cclauss
cclauss merged commit 927c7d3 into TheAlgorithms:master Sep 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files git merge conflict

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split silently returns wrong result for multi-character separators

4 participants