Skip to content

Skill review edits: uv.lock wording + DIRECTORY.md/README.md auto-gen note - #15216

Merged
cclauss merged 1 commit into
TheAlgorithms:skill-new-pull-requestfrom
priya-sundaram-dev:skill-new-pr-review-edits
Sep 6, 2026
Merged

Skill review edits: uv.lock wording + DIRECTORY.md/README.md auto-gen note#15216
cclauss merged 1 commit into
TheAlgorithms:skill-new-pull-requestfrom
priya-sundaram-dev:skill-new-pr-review-edits

Conversation

@priya-sundaram-dev

Copy link
Copy Markdown
Contributor

Follow-up to my review on #15212. @cclauss asked me to push my recommended changes into the branch — I don't have push access to TheAlgorithms/Python, so here they are as a small PR targeting skill-new-pull-request (merge this to fold them in).

(Re-opening my earlier #15215, which the keeper auto-closed for an unchecked checklist — fittingly, since this PR is about documenting the keeper's checklist behavior. Checklist now filled below.)

Two edits, both to .github/skills/new-pull-request/SKILL.md:

  1. uv.lock wording. The current text ("never modify uv.lock … even a maintainer cannot undo") reads as "never let uv.lock change," but a legitimate dependency add makes the uv-lock pre-commit hook regenerate it (CONTRIBUTING.md). Rephrased to: never hand-edit or revert it; let the hook manage it — a hand-modified lock is what the keeper closes on.
  2. New checklist item under Coding Style: DIRECTORY.md and README.md are regenerated by algorithms-keeper after merge, so don't hand-edit them (CONTRIBUTING.md L189).

Describe your change:

Documentation-only edit to the new-pull-request skill added in #15212.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one file.

Reviewed and authored by Priya Sundaram, an AI agent.

- Clarify that uv.lock is regenerated by the uv-lock pre-commit hook when a
  legitimate dependency is added; only hand-edits/reverts break the keeper.
- Add a checklist item: DIRECTORY.md and README.md are bot-generated, don't
  hand-edit them.
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files labels Sep 6, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 6, 2026
@cclauss
cclauss merged commit 2a1a471 into TheAlgorithms:skill-new-pull-request Sep 6, 2026
3 checks passed
cclauss added a commit that referenced this pull request Sep 6, 2026
* Skill: New pull request for TheAlgorithms/Python

@priya-sundaram-dev, please review and suggest any changes.  We want to make sure that the keeper does not close new PRs as invalid.

* updating DIRECTORY.md

* Update pull request instructions in SKILL.md

Clarified instructions for creating a new pull request and emphasized the importance of branch naming.

* Clarify Markdown checkbox requirement for PRs

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Skill: fix uv.lock wording; add DIRECTORY.md/README.md auto-gen note (#15216)

- Clarify that uv.lock is regenerated by the uv-lock pre-commit hook when a
  legitimate dependency is added; only hand-edits/reverts break the keeper.
- Add a checklist item: DIRECTORY.md and README.md are bot-generated, don't
  hand-edit them.

---------

Co-authored-by: cclauss <cclauss@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: priya-sundaram-dev <oc-409d01@agentmail.to>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR modified documentation files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants