Skip to content

Improve binary insertion sort comparable typing - #15238

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
snehapriy958:fix/binary-insertion-comparable
Sep 9, 2026
Merged

Improve binary insertion sort comparable typing#15238
cclauss merged 5 commits into
TheAlgorithms:masterfrom
snehapriy958:fix/binary-insertion-comparable

Conversation

@snehapriy958

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes sorts: make algorithms sort any comparable items, not just ints #15234 ".

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 9, 2026
@algorithms-keeper

algorithms-keeper Bot commented Sep 9, 2026

Copy link
Copy Markdown

Multiple Pull Request Detected

@snehapriy958, we are extremely excited that you want to submit multiple algorithms in this repository but we have a limit on how many pull request a user can keep open at a time. This is to make sure all maintainers and users focus on a limited number of pull requests at a time to maintain the quality of the code.

This pull request is being closed as the user already has an open pull request. Please focus on your previous pull request before opening another one. Thank you for your cooperation.

User opened pull requests (including this one):

@algorithms-keeper algorithms-keeper Bot closed this Sep 9, 2026
@cclauss cclauss reopened this Sep 9, 2026
@algorithms-keeper algorithms-keeper Bot added the enhancement This PR modified some existing files label Sep 9, 2026
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Sep 9, 2026
@cclauss cclauss added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Sep 9, 2026
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass labels Sep 9, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 9, 2026
@cclauss
cclauss merged commit d0f9b6e into TheAlgorithms:master Sep 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorts: make algorithms sort any comparable items, not just ints

2 participants