Skip to content

Make bubble sort support comparable items - #15241

Closed
Rokesh2008 wants to merge 1 commit into
TheAlgorithms:masterfrom
Rokesh2008:fix/bubble-sort-comparable
Closed

Make bubble sort support comparable items#15241
Rokesh2008 wants to merge 1 commit into
TheAlgorithms:masterfrom
Rokesh2008:fix/bubble-sort-comparable

Conversation

@Rokesh2008

Copy link
Copy Markdown

Fixes #15234 for bubble_sort.py.

This contribution:

  • models both bubble-sort functions with a Comparable protocol and TypeVar
  • uses lt for comparison-sort semantics
  • adds doctests and pytest coverage for mixed, non-comparable input

Tests:

  • python -m pytest tests/test_sorts.py -q
  • python -m doctest sorts/bubble_sort.py

Both commands pass.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 9, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Rokesh2008, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot closed this Sep 9, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 9, 2026
@cclauss cclauss reopened this Sep 9, 2026
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files invalid tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorts: make algorithms sort any comparable items, not just ints

2 participants