Skip to content

sorts: type gnome sort for comparable items - #15253

Closed
HarshRajSinghania wants to merge 2 commits into
TheAlgorithms:masterfrom
HarshRajSinghania:sorts/comparable-gnome-sort
Closed

sorts: type gnome sort for comparable items#15253
HarshRajSinghania wants to merge 2 commits into
TheAlgorithms:masterfrom
HarshRajSinghania:sorts/comparable-gnome-sort

Conversation

@HarshRajSinghania

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Details

Type gnome_sort to accept comparable items rather than only integers.

  • Adds Comparable typing.
  • Adds comparable string/float doctests.
  • Extends the existing mixed-type rejection test for gnome_sort.

Part of #15234. This intentionally contains one algorithm per pull request, following the issue guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant