Make gnome sort generic over comparable items - #15261
Merged
Merged
Conversation
bpiper02
force-pushed
the
type-gnome-sort
branch
from
September 9, 2026 23:22
3790faa to
db52ade
Compare
Member
|
@priya-sundaram-dev, your review, please. |
priya-sundaram-dev
approved these changes
Sep 10, 2026
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
LGTM ✅
The subtle part here is the guard change from `lst[i - 1] <= lst[i]` to `not lst[i] < lst[i - 1]`, needed because `Comparable` only supplies `lt`. That rewrite is exactly right:
- Equivalent: for a total order `a <= b` ≡ `not (b < a)`, so the loop advances/swaps identically.
- Stability preserved: equal elements give `lst[i] < lst[i-1] == False` → advance, no swap — same as before.
- Protocol-safe: the body now only ever calls `lt`, matching the `Comparable` bound.
I re-ran it locally: 3000 random lists match `sorted`, and a stability check (2000 runs, wrapper comparing on key only) stays stable. Adding `gnome_sort` to the shared `rejects_non_comparable` coverage is the right move too.
Nice, minimal change — consistent with the rest of #15234.
cclauss
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15234
Updates
gnome_sortto use a bounded comparable type instead of an untypedlist.Also adds
gnome_sortto the shared test covering rejection of non-comparable mixed items.Validation:
python -m doctest -v sorts/gnome_sort.pypython -m pytest tests/test_sorts.py -k "gnome_sort or rejects_non_comparable"python -m ruff check sorts/gnome_sort.py tests/test_sorts.pypython -m ruff format --check sorts/gnome_sort.py tests/test_sorts.pypython -m compileall sorts/gnome_sort.py