Added an algorithm in how to use genetic algorithm for numbers - #9577
Open
harshajv7981 wants to merge 19 commits into
Open
Added an algorithm in how to use genetic algorithm for numbers#9577harshajv7981 wants to merge 19 commits into
harshajv7981 wants to merge 19 commits into
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return input_value**2 - 3 * input_value + 2 | ||
|
|
||
|
|
||
| def genetic_algorithm(): |
There was a problem hiding this comment.
Please provide return type hint for the function: genetic_algorithm. If the function does not return a value, please provide the type hint as: def function() -> None:
Author
|
Updated |
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks @harshajv7981. The fitness_function part is fine (type hints + working doctests), but I think the core needs rethinking before this fits genetic_algorithm/:
- It isn't a genetic algorithm.
genetic_algorithm()draws 100 random numbers once and returns the best by fitness — that's a single round of random search, with no population evolution: no selection, crossover, mutation, or generations. A GA contribution should show at least those steps iterating over multiple generations (seegenetic_algorithm/basic_string.pyin the repo for the expected shape). - The doctests don't validate anything. Both assertions in
genetic_algorithm()are written to evaluate toFalseand expectFalse:So the doctest "passes" without demonstrating a correct result. (For reference,>>> abs(best_solution - (-1.45)) < 0.1 Falsex**2 - 3x + 2is minimised atx = 1.5on[-2, 2], giving-0.25, so-1.45/6.0aren't the target anyway.) After reworking into a real GA, please seed RNG and assert a meaningful convergence property.
Happy to re-review once it evolves a population over generations — the fitness scaffolding is a good start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: