Repository navigation
Fix bubble map colorbar title and p-value column name issue - #65
Open
SuhasSrinivasan wants to merge 3 commits into
Open
SuhasSrinivasan wants to merge 3 commits into
SuhasSrinivasan wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the handling and visualization of MEA enrichment results, focusing on better support for custom column names and enhanced labeling in bubble-map plots. The changes improve both the flexibility and clarity of the enrichment analysis workflow, especially for users working with MEA NES and p-value data. The update also includes new and expanded test coverage for these features.
Key changes include:
Customization and Flexibility in Bubble-map Plotting
plot_bubblemapfunction now supports optional argumentslff_cbar_titleandpval_legend_title, allowing users to customize the colorbar and p-value legend titles [1] [2] [3] [4].plot_bubblemapand related parameters have been updated for clarity, reflecting the new customization options and making the documentation more accurate and user-friendly [1] [2] [3] [4].Improved MEA Enrichment Results Combination
combine_mea_enrichment_resultsfunction now prefers the native MEAp-valuecolumn for unadjusted p-values, while still supporting the legacypvaluespelling. This ensures more accurate and robust handling of MEA result tables with varying column names [1] [2] [3].Expanded and Updated Test Coverage
Documentation
CHANGELOG.mdhas been updated to reflect the new features and bugfixes, including the ability to customize bubble-map colorbar and legend titles and improved MEA result combination logic.Testing Environment
MPLBACKENDenvironment variable to"Agg"to ensure matplotlib tests run headlessly and deterministically.