fix: tighten the gap between the page menu and the tab menu - #651
Merged
Conversation
The two menus are one navigation block -- page above, that page's tabs
below -- but they were separated by enough space to read as two
unrelated bands.
Three values sat between them, in different files, none individually
obviously wrong:
WordmarkNav item margin bottom 3 -> 1 (kept 1 so the row still
separates when it wraps on
a narrow window)
wordmark bar grid margin bottom 2 -> 0
content host padding top 4 -> 0
Eight pixels out of nine. What is left is the type's own leading, which
would need a negative margin or a LineHeight override to trim -- both
risk clipping descenders on "mapping" and "pressure", so they are not
worth it for the last few pixels.
The content padding is shared, so pages with no tab menu (Home,
Scribble) move up by the same amount and stay aligned with the pivoted
ones.
Verified live on tablet, settings and home.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two menus are one navigation block — the page above, that page'"'"'s tabs below — but they were separated by enough space to read as two unrelated bands.
Three values, three files
None of them individually looked wrong, which is why the gap survived this long:
WordmarkNavitem margin3→12→04→0Eight pixels out of nine. What remains is the type'"'"'s own leading, which would need a negative margin or a
LineHeightoverride to trim — both risk clipping descenders on "mapping" and "pressure", so they are not worth it for the last few pixels. Happy to go further if you want it tighter still.Note
The content padding is shared, so pages with no tab menu (Home, Scribble) move up by the same amount and stay aligned with the pivoted ones — worth checking that reads right to you, since it is the one part of this that touches pages the request was not about.
Verified live on tablet (5 tabs), settings (5 tabs) and home (no tab menu).
🤖 Generated with Claude Code