fix: drop the tab menu a step, to 40 - #652
Merged
Merged
Conversation
The pivot row was 44, shared with TextBlock.Display. Splitting the token rather than shrinking both: the request was for the tab menu, and TypeDisplaySize also drives Home's section headings, which were not asked to change. TypeDisplaySize 44 section headings (TextBlock.Display) — unchanged TypePivotSize 40 pivots (PivotTab) — new They are still the same layer conceptually and never appear together (a page has pivots OR display headings, never both), so the step between them is never seen side by side. Worth keeping them within a step of each other. Tracking scales with the size, -1.4 -> -1.3, so the pivots keep the same optical tightness rather than looking looser at the smaller size. PivotTab sets its size TWICE — the visible run and the invisible width reserver that stops the row reflowing when the active item gains weight. Both moved together; verified by clicking between pivots and confirming every word holds its exact x position. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tab menu goes from 44 to 40 — the 10% asked for.
One decision worth surfacing
TypeDisplaySize(44) was shared by the pivot row andTextBlock.Display, which is Home'"'"'sneeds attention/your tabletsheadings. Shrinking the token would have shrunk Home too, which was not the request — so the token is split instead:TypeDisplaySizeTypePivotSizeThey remain the same layer conceptually and never appear together — a page has pivots or display headings, never both — so the step between them is never seen side by side. Worth keeping them within a step of each other; the comment in
App.axamlsays so.If you would rather Home followed the tab menu down, that is a one-line change: point
TextBlock.DisplayatTypePivotSizeand drop the extra key.Details
-1.4→-1.3, so the pivots keep the same optical tightness instead of looking looser at the smaller size.PivotTabsets its size twice — the visible run and the invisible width reserver that stops the row reflowing when the active item gains weight. Both moved together. Verified by clicking between pivots and confirming every word holds its exact x position; a mismatch here would have shifted the whole row on every click.Build clean, 673/673.
🤖 Generated with Claude Code