feat: drop the row icons from the presets and plugins lists - #663
Merged
Conversation
Both lists put the same glyph in front of every row — a card outline on presets, a toy brick on plugins. Identical on every row, so neither distinguished anything; they just held a fixed column of decoration in front of each name and pushed the names off the left margin the headings and body text share. Home's tablet list lost its monitor icon for the same reason in #656. This brings the other two object lists in line, so an Entity row reads the same wherever it appears. IconCardBulletedOutline and IconToyBrickOutline each had exactly one consumer, so both are removed from Icons.axaml too — as IconMonitor was. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the leading glyph from every row of the presets and installed plugins lists.
Why
Each list put the same icon in front of every row — a card outline on presets, a toy brick on plugins. Identical across rows, so neither distinguished anything; they held a fixed column of decoration in front of each name and pushed the names off the left margin that the headings and body text share.
Home's tablet list lost its monitor icon for exactly this reason in #656. This brings the other two object lists in line, so a
c:Entityrow reads the same wherever it appears.Also removed
IconCardBulletedOutlineandIconToyBrickOutlinehad exactly one consumer each — the rows above — so both are dropped fromIcons.axamlas well.IconMonitorwent the same way in #656.This is the one part beyond the literal request; easy to restore if you would rather keep the paths.
For the reviewer
Verified in the running app on both pages: names now start on the same left margin as their section heading.
3 files, 2 insertions, 4 deletions. 678/678.