Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pkgdown.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ jobs:
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-pandoc@v1
- uses: r-lib/actions/setup-pandoc@v2

- uses: r-lib/actions/setup-r@v1
- uses: r-lib/actions/setup-r@v2
with:
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v1
- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: pkgdown
needs: website
Expand Down
14 changes: 7 additions & 7 deletions R/utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,13 @@ sample_state_level <- function(vol, local = "en_US") {
)
}

sample_source_call <- function(vol, local = "en_US") {
source_level <- c(
"Local",
"France",
"Europe",
"International"
)
sample_source_call <- function(vol, local = c("en_US", "fr_FR")) {
local <- match.arg(local)
source_level <- if (local == "fr_FR") {
c("Local", "France", "Europe", "International")
} else {
c("Local", "US", "Europe", "International")
}
factor(
sample(source_level, vol, replace = TRUE),
source_level
Expand Down
33 changes: 33 additions & 0 deletions tests/testthat/test-locale.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
test_that("fake_ticket_client(local = 'en_US') has no French tokens in source_call (#9)", {
df <- fakir::fake_ticket_client(vol = 200, local = "en_US", seed = 42)
# The source_call column in en_US mode should not include "France"
# (that is the French-locale label).
expect_false("France" %in% levels(df$source_call))
expect_false("France" %in% as.character(df$source_call))
})

test_that("fake_ticket_client(local = 'fr_FR') keeps French tokens", {
df <- fakir::fake_ticket_client(vol = 200, local = "fr_FR", seed = 42)
expect_true("France" %in% as.character(df$source_appel) ||
"Europe" %in% as.character(df$source_appel))
})

test_that("sample_source_call rejects unknown locales (#9)", {
expect_error(
fakir:::sample_source_call(10, local = "de_DE"),
regexp = "should be one of"
)
})

test_that("sample_source_call is locale-aware", {
skip_if_not(exists("sample_source_call", envir = asNamespace("fakir")))
withr::with_seed(
seed = 1,
{
en <- fakir:::sample_source_call(200, local = "en_US")
fr <- fakir:::sample_source_call(200, local = "fr_FR")
}
)
expect_false("France" %in% levels(en))
expect_true("France" %in% levels(fr) || "France" %in% as.character(fr))
})
Loading