ff-710 The "undo read" button moved from the sidebar to the top toolbar - #537
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new icon-only undo buttons need accessible labels (e.g., aria-label) so the action remains identifiable to assistive tech.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR implements ff-710 by moving the “undo read” action from the sidebar area into a top toolbar on the News and Public Collection views, while consolidating toolbar UI and tooltip behavior.
Changes:
- Replace the sidebar “undo mark read” button with a top
UiToolbarcontaining an undo action (icon button) and theProductTokensdisplay. - Introduce a reusable
UiToolbarcomponent and shiftProductTokensto self-load product state (removingNewsToolbar). - Standardize tooltips by adding a
tooltipprop toUiButtonbacked byAppTooltip, plus add anundoicon mapping and update docs/changelog.
File summaries
| File | Description |
|---|---|
| specs/frontend_architecture/components.md | Document exception allowing local component imports when rendered via dynamic <component :is>. |
| site/src/views/PublicCollectionView.vue | Move undo action into the new top toolbar and add ProductTokens to the right side. |
| site/src/views/NewsView.vue | Move undo action into the new top toolbar and add ProductTokens to the right side. |
| site/src/values/Icon.vue | Add undo icon mapping backed by IconArrowBackUp. |
| site/src/main.ts | Register UiToolbar globally and remove NewsToolbar registration. |
| site/src/components/ui/Toolbar.vue | New toolbar layout component with left/right slots. |
| site/src/components/ui/Button.vue | Add tooltip prop and wrap button with AppTooltip, forwarding attrs to the native <button>. |
| site/src/components/ProductTokens.vue | Make ProductTokens self-sufficient by fetching product state internally and gating on login. |
| site/src/components/NewsToolbar.vue | Remove legacy toolbar component (replaced by UiToolbar + ProductTokens). |
| site/src/components/AppTooltip.vue | Adjust focus handling to show tooltips only when the trigger is :focus-visible. |
| changes/unreleased.md | Add release note entry for ff-710. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+52
to
+57
| <ui-button | ||
| variant="tonal" | ||
| size="compact" | ||
| tooltip='Undo last "mark read" operation' | ||
| :disabled="!entriesStore.canUndoMarkRead" | ||
| @click="entriesStore.undoMarkRead()"> |
Comment on lines
+58
to
+63
| <ui-button | ||
| variant="tonal" | ||
| size="compact" | ||
| tooltip='Undo last "mark read" operation' | ||
| :disabled="!entriesStore.canUndoMarkRead" | ||
| @click="entriesStore.undoMarkRead()"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.