Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PpsWidthsetting during oscillator initializationMotivation
The repository already lists
{set,PpsWidth,80000000}as a minimum required SA53 setting, but oscillatord did not enforce it. On hardware, a missing width caused the Time Card PHC to remainunsyncedafter boot with a stable offset of hundreds of milliseconds, while GNSS and MAC PPS remained closely aligned.The setting is applied at daemon startup. It is not stored to EEPROM, avoiding unnecessary flash writes while ensuring every oscillatord run establishes the required output geometry.
Testing
Ran the same Ubuntu 24.04 build used by
.github/workflows/oscillatord.yml:The new test uses a pseudo-terminal SA5x responder and verifies that oscillatord sends
{set,PpsWidth,80000000}only when the reported value differs.