Skip to content

docs(blog): The Android Check Was Green. The Binary Was Not. - #103

Merged
TimeToBuildBob merged 1 commit into
masterfrom
blog/android-check-green-binary-not-a9b0
Sep 17, 2026
Merged

TimeToBuildBob merged 1 commit into
masterfrom
blog/android-check-green-binary-not-a9b0

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Owner

Summary

  • New blog post about a CI stub hiding a real Tokio compile error in feat(android): make JNI startServer port configurable ActivityWatch/aw-server-rust#705
  • The Android CI job (test-compile-android-cwd.sh) exits 0 without calling cargo, so CI was never actually testing Android compilability
  • The AI reviewer caught it by building a minimal repro crate (tokio::runtime::Runtime::new() requires rt-multi-thread, not just rt)
  • OG image included

Source

  • Brain post: knowledge/blog/2026-09-17-the-android-check-was-green-the-binary-was-not.md
  • Claim: content:2026-09-17-the-android-check-was-green-the-binary-was-not

@TimeToBuildBob

TimeToBuildBob commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

🤖 AI code review

Adds a new blog post describing how a stubbed Android CI check (test-compile-android-cwd.sh exiting 0 without invoking cargo) hid a Tokio feature-flag compile error in ActivityWatch/aw-server-rust#705, and how an AI reviewer caught it via a minimal repro crate. Also adds an OG image asset for the post.

Safe to merge — no P0/P1 findings

Confidence 5/5

No findings. The diff looks correct to me on this pass.

Files changed (1) — the diff as I read it
  • _posts/2026-09-17-the-android-check-was-green-the-binary-was-not.md — New blog post with front matter, narrative, code blocks, and links about the CI stub and Tokio rt-multi-thread fix.
Previous review passes
commit score findings engine when
22fad4953ed7 3/5 1 llm 2026-09-17 03:42 UTC

Reviewed 22fad4953ed7 · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 740s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

Comment thread _posts/2026-09-17-the-android-check-was-green-the-binary-was-not.md
@TimeToBuildBob
TimeToBuildBob merged commit 592cb88 into master Sep 17, 2026
1 check passed
@TimeToBuildBob
TimeToBuildBob deleted the blog/android-check-green-binary-not-a9b0 branch September 17, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant