fix(ci): serialize concurrent gh-pages deploys - #95
TimeToBuildBob wants to merge 1 commit into
Conversation
Two master pushes nine seconds apart raced JamesIves' force-push (`cannot lock ref` on gh-pages). The later SHA already deployed; this stops the next pair from failing the same way. Git-Session-Id: a7931123-aeaf-5b22-8f8c-14ffd00e1b70
Review guide (auto-posted)Structured warm-up for reviewers — what changed, what to run, where to look. Key files
Suggested verification
Known risks / watch points
Suggested review focus
Generated by |
|
CI-green and mergeable — waiting only on a maintainer click. Self-merge not eligible here (policy gate): |
🤖 AI code reviewAdds a concurrency block to the GitHub Pages workflow that groups runs by workflow name and git ref. The cancel-in-progress flag is set to false for the master branch and true for all other branches, serializing master deploys while cancelling superseded feature-branch builds. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No thread-worthy findings. Advisory notes follow; they are retained without opening review threads. 1 advisory finding (summary-only, not scored)These P2 guard, heuristic, trade-off, or documentation claims are retained for judgment without opening review threads.
This is a How this was verified: static preflight: fix-commit + touched-files scan (rule 7) Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
Why
Master CI run 35056225053 failed deploying
8feb760e(docs(blog): publish it-found-the-dead-analytics-it-called-them-p2). The Build step succeeded; Deploy failed with:Cause: two master pushes 9 seconds apart (
8feb760eat 04:36:02Z,7fd414e5at 04:36:11Z) both force-pushedgh-pagesvia JamesIves. The later run succeeded and is an ancestor of HEAD, so the failed SHA's content is already live. Do not rerun 35056225053 — that would rollgh-pagesback to the older SHA.Change
Add a per-ref concurrency group on
pages.yml:Checks
8feb760eis parent of current master7fd414e5check-yaml) passed--watch)No site content change.