Replace Node runtime with composite action - #20
Merged
Merged
Conversation
The Node entrypoint only spawned start.sh, so every Node runtime deprecation (node12 -> node16 -> node20 -> node24) forced a release. A composite action runs the script directly and never deprecates. Also bumps the CI workflow off deprecated action versions and adds a smoke test that the action still wires up and runs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X1sz7entAqb4B2Hycm9YF4
pre-commit-hooks v4.2.0 -> v6.0.0, shellcheck-py v0.8.0.4 -> v0.11.0.1, doctoc v2.1.0 -> v2.5.0. All hooks pass on the current tree. Removed the debug-statements hook: it only inspects Python files and this repo has none. checkout v4 -> v7, and setup-python is gone entirely since pipx and python are preinstalled on the runners. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X1sz7entAqb4B2Hycm9YF4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the runner warning:
What
start.jsdid nothing butspawn('bash', ['start.sh']). That shim is the only reason this action has a Node runtime — and the only reason it needs a release every time GitHub deprecates one (node12 → node16 → node20 → node24).Switched
runs.usingtocomposite, which invokesstart.shdirectly and has no runtime version to deprecate.start.jsis deleted.Inputs are mapped explicitly to the
INPUT_*env varsstart.shalready reads, so the script is unchanged and behaviour is identical (including theforce/tagsempty-string →falsedefaults).Also
actions/checkout@v2→@v4,actions/setup-python@v2→@v5, andpre-commit/action@v2.0.3replaced withpipx run pre-commit(one less action to keep bumping).uses: ./and asserts it still executes and fails on missing input — catches the composite wiring breaking.🤖 Generated with Claude Code
https://claude.ai/code/session_01X1sz7entAqb4B2Hycm9YF4