Skip to content

Compare boolean inputs instead of executing them #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobKed merged 3 commits into from
Aug 22, 2026
Merged

Compare boolean inputs instead of executing them #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f56d67a
Compare boolean inputs instead of executing them
TobKed Aug 22, 2026
4657ac2
Replace test_start.sh with a pygrep lint hook
TobKed Aug 22, 2026
a17dcce
Close the quoted/loop gap in the no-input-eval hook
TobKed Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
pull_request:
branches: [master]

permissions:
contents: read

jobs:
statics:
name: Static checks
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.DS_Store
.idea/
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,10 @@ repos:
- "4"
- "--title"
- "**Table of Contents**"
- repo: local
hooks:
- id: no-input-eval
name: Inputs must be compared, not executed
language: pygrep
entry: '(if|elif|while|until) +"?\$\{?INPUT_'
files: ^start\.sh$
4 changes: 2 additions & 2 deletions start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ echo "Synchronizing repository ${TARGET_REPOSITORY}:${INPUT_TARGET_BRANCH} with
exit 1;
};

if ${INPUT_FORCE}; then
if [ "${INPUT_FORCE}" = "true" ]; then
_FORCE_OPTION='--force'
fi

if ${INPUT_TAGS}; then
if [ "${INPUT_TAGS}" = "true" ]; then
_TAGS='--follow-tags --tags'
fi

Expand Down
Loading