Skip to content

More accurate VBR durations #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DXCanas wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

More accurate VBR durations #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04e1edb
Use precise timing extraction for opus, ogg, and mp3 during import
DXCanas Aug 1, 2026
4419e68
Use precise timing extraction for opus, ogg, and mp3 during sync chap…
DXCanas Aug 1, 2026
33538a2
Use precise timing extraction for opus, ogg, and mp3 during sync down…
DXCanas Aug 1, 2026
fdaecc3
Add concise code comments explaining precise duration necessity for M…
DXCanas Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Shared/Services/AudioMetadataService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ public class AudioMetadataService: BPLogger, AudioMetadataServiceProtocol {
public init() {}

public func extractMetadata(from fileURL: URL) async -> AudioMetadata? {
let asset = AVURLAsset(url: fileURL)
// MP3 and Ogg lack global duration headers. We request precise timing to prevent
// inaccurate duration estimates for VBR files by forcing a full stream scan.
let requiresPreciseDuration = ["opus", "ogg", "mp3"].contains(fileURL.pathExtension.lowercased())
let options: [String: Any]? = requiresPreciseDuration ? [AVURLAssetPreferPreciseDurationAndTimingKey: true] : nil
let asset = AVURLAsset(url: fileURL, options: options)
return await extractMetadata(from: asset)
}

Expand Down Expand Up @@ -232,7 +236,11 @@ public class AudioMetadataService: BPLogger, AudioMetadataServiceProtocol {
}

public func extractManualChapters(from fileURL: URL) async -> [ChapterMetadata]? {
let asset = AVURLAsset(url: fileURL)
// MP3 and Ogg lack global duration headers. We request precise timing to prevent
// inaccurate duration estimates for VBR files by forcing a full stream scan.
let requiresPreciseDuration = ["opus", "ogg", "mp3"].contains(fileURL.pathExtension.lowercased())
let options: [String: Any]? = requiresPreciseDuration ? [AVURLAssetPreferPreciseDurationAndTimingKey: true] : nil
let asset = AVURLAsset(url: fileURL, options: options)
do {
let metadata = try await asset.load(.metadata)
let duration = CMTimeGetSeconds(try await asset.load(.duration))
Expand Down
8 changes: 7 additions & 1 deletion Shared/Services/LibraryService+Sync.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,12 @@ extension LibraryService: LibrarySyncProtocol {
public func loadChaptersIfNeeded(relativePath: String) async {
let fileURL = DataManager.getProcessedFolderURL().appendingPathComponent(relativePath)

await loadChaptersIfNeeded(relativePath: relativePath, asset: AVAsset(url: fileURL))
// MP3 and Ogg lack global duration headers. We request precise timing to prevent
// inaccurate duration estimates for VBR files by forcing a full stream scan.
let requiresPreciseDuration = ["opus", "ogg", "mp3"].contains(fileURL.pathExtension.lowercased())
let options: [String: Any]? = requiresPreciseDuration ? [AVURLAssetPreferPreciseDurationAndTimingKey: true] : nil
let asset = AVURLAsset(url: fileURL, options: options)

await loadChaptersIfNeeded(relativePath: relativePath, asset: asset)
}
}
6 changes: 5 additions & 1 deletion Shared/Services/Sync/SyncService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,11 @@ extension SyncService {

let actualDuration: Double
do {
let asset = AVURLAsset(url: fileURL)
// MP3 and Ogg lack global duration headers. We request precise timing to prevent
// inaccurate duration estimates for VBR files by forcing a full stream scan.
let requiresPreciseDuration = ["opus", "ogg", "mp3"].contains(fileURL.pathExtension.lowercased())
let options: [String: Any]? = requiresPreciseDuration ? [AVURLAssetPreferPreciseDurationAndTimingKey: true] : nil
let asset = AVURLAsset(url: fileURL, options: options)
actualDuration = CMTimeGetSeconds(try await asset.load(.duration))
} catch {
/// We have a trustworthy synced duration, so this is a format we can play —
Expand Down