Localize Pi provider injection to each Workspace - #981
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.pi/extensions/openalice-provider.ts.pi/openalice-provider.jsonsidecarRoot cause
OpenAlice previously wrote every Workspace custom provider into Pi’s user-global
models.json. Concurrent Workspace launches could race on that shared file, leak Workspace-specific defaults across scopes, and leave projectdefaultModelselection pointing at a different global provider model. The extension API also requires complete model objects, unlikemodels.json, so the local projection supplies Pi’s own documented compatibility defaults at registration time.User impact
Pi model and credential injection is now isolated per Workspace. Automated Issues and resumed Sessions use the Workspace provider without mutating global Pi model configuration, while user-owned global configuration remains visible and untouched. Existing installations migrate automatically with a backup and keep a legacy global provider whenever one Workspace cannot be localized safely.
Verification
npx tsc --noEmitpnpm test— 3916 passed, 9 skipped--list-modelsdiscovery from the local extensionCSC_IDENTITY_AUTO_DISCOVERY=false pnpm electron:smoke:workspace— packaged Electron, PTY/CLI, scheduled Issue, managed Pi response, migration, and cleanup all passed