Fixed uri in examples - #1064
Open
Micovec wants to merge 2 commits into
Open
Conversation
skinkie
approved these changes
Aug 16, 2026
Contributor
|
@Micovec again thanks for the QA! |
Contributor
Contributor
Contributor
|
@TuThoThai how is this 'check parent branch' solvable? |
Contributor
2 ways of doing it, generally speaking:
I went with the 2nd option in the PR preceding this one (#1060). I am waiting for review on that one to merge. Then, I will run the CI again on this one. |
Contributor
|
I think both ways are not aligned with how git is supposed to be used. I think it is the maintainers jobto regularly synchronise these branches and not to be done on the individual PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some invalid URIs, as per reported in #1063
Fixes: #1063