Skip to content

Fixed uri in examples - #1064

Open
Micovec wants to merge 2 commits into
v2.1-wipfrom
bugfix_uri_in_examples
Open

Fixed uri in examples#1064
Micovec wants to merge 2 commits into
v2.1-wipfrom
bugfix_uri_in_examples

Conversation

@Micovec

@Micovec Micovec commented Aug 16, 2026

Copy link
Copy Markdown

This PR fixes some invalid URIs, as per reported in #1063

Fixes: #1063

@Micovec Micovec changed the title Bugfix uri in examples Fixed uri in examples Aug 16, 2026
@skinkie

skinkie commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@Micovec again thanks for the QA!

@skinkie skinkie added the typo Typo (comment or mispelling) correction without any technical impact label Aug 16, 2026
@skinkie

skinkie commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@thbar I need instruction how to fix parent branch stuff.

@Micovec I wonder if we could add a URI validation rule for XmlnsUrl.

@TuThoThai

Copy link
Copy Markdown
Contributor

@skinkie, there is one commit to backport from v2.0 to v2.1-wip. I have embedded it in Matthias' latest PR (#1060). When we merge that one, then all upcoming PRs on v2.1-wip should pass the 1st CI check.

@TuThoThai TuThoThai linked an issue Aug 17, 2026 that may be closed by this pull request
@skinkie

skinkie commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@TuThoThai how is this 'check parent branch' solvable?

@TuThoThai

Copy link
Copy Markdown
Contributor

@TuThoThai how is this 'check parent branch' solvable?

2 ways of doing it, generally speaking:

  • create a PR that also targets v2.1-wip every time there is a change done on v2.0, so both are always aligned
  • embedd in the latest PR for v2.1-wip the commits that are present in v2.0 and not yet backported

I went with the 2nd option in the PR preceding this one (#1060). I am waiting for review on that one to merge. Then, I will run the CI again on this one.

@ue71603

ue71603 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

I think both ways are not aligned with how git is supposed to be used. I think it is the maintainers jobto regularly synchronise these branches and not to be done on the individual PR.

@TuThoThai TuThoThai added this to the netex_2.1 milestone Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo Typo (comment or mispelling) correction without any technical impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid URI in some examples

4 participants