Complete input presentation and retained sidebar integration - #4
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d03df3fbd0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: format!( | ||
| "link-{}-{:?}-{link_ix}-{part_ix}", | ||
| self.link_source_offset, self.id | ||
| ) |
There was a problem hiding this comment.
Use layout-independent IDs for link fragments
When link_with is used in an InlineFlow, self.id comes from elements.len() in inline_flow.rs, so resizing can renumber a later link whenever preceding text wraps into a different number of positioned fragments. Embedding that transient value in the advertised stable LinkFragment.id also changes the associated retained focus state, causing a focused decorated link to lose keyboard focus during reflow. Derive the fragment/global identity from a stable item or document offset instead of the rendered-fragment ordinal.
Useful? React with 👍 / 👎.
Complete the GPUI 0.6 input migration by forwarding the existing TextInputConfiguration and exposing ordinary Textarea presentation ranges through the existing decoration renderer. Search uses the platform Search action. Authored styles preserve text, selection and active composition; whole-text replacement clears old presentation ranges. Two retained component doctests now import their actual owning crates.
Sidebar consumers can now decorate the actual clickable menu row and retained toggle button. The row hook excludes expanded submenus, so a semantic action targets the row's measured geometry. The toggle hook runs after its existing icon, label and handler are bound. Both hooks preserve the existing default mechanics and avoid another interactive wrapper. Row decorations compose in call order, so a native tab stop survives the semantic binding and GPUI delivers Enter and Space through the same click closure.
Current head:
b81a688dc71661b7120bed7bba6085accd4ffe49. All seven GPUI manifest pins and 25 lock source URLs remain at Zedde1d65ee70ac21a1ef02a500151a96d96ff937e1. The sidebar addition changes two component source files and adds ordered patches 0023 and 0024; it changes no dependency version, checksum or edge. The 24-patch series replays exactly from upstream v0.6.0.Validation:
Review is required before merging this draft. These shared primitives contain no Theorem document or reducer state.