Skip to content

Complete input presentation and retained sidebar integration - #4

Merged
Travis-Gilbert merged 24 commits into
Codex/gpui-kit-0.6-settingsfrom
codex/gpui-web-ime-integration
Sep 5, 2026
Merged

Travis-Gilbert merged 24 commits into
Codex/gpui-kit-0.6-settingsfrom
codex/gpui-web-ime-integration

Conversation

@Travis-Gilbert

@Travis-Gilbert Travis-Gilbert commented Sep 5, 2026 •

Copy link
Copy Markdown
Owner

Complete the GPUI 0.6 input migration by forwarding the existing TextInputConfiguration and exposing ordinary Textarea presentation ranges through the existing decoration renderer. Search uses the platform Search action. Authored styles preserve text, selection and active composition; whole-text replacement clears old presentation ranges. Two retained component doctests now import their actual owning crates.

Sidebar consumers can now decorate the actual clickable menu row and retained toggle button. The row hook excludes expanded submenus, so a semantic action targets the row's measured geometry. The toggle hook runs after its existing icon, label and handler are bound. Both hooks preserve the existing default mechanics and avoid another interactive wrapper. Row decorations compose in call order, so a native tab stop survives the semantic binding and GPUI delivers Enter and Space through the same click closure.

Current head: b81a688dc71661b7120bed7bba6085accd4ffe49. All seven GPUI manifest pins and 25 lock source URLs remain at Zed de1d65ee70ac21a1ef02a500151a96d96ff937e1. The sidebar addition changes two component source files and adds ordered patches 0023 and 0024; it changes no dependency version, checksum or edge. The 24-patch series replays exactly from upstream v0.6.0.

Validation:

  • Local ordered series replay matches the current source. Before publication, the actual AGPUI consumer library bound to staged Kit paths passed 159/159 native tests, including measured row/toggle pointer and semantic activation, real Enter and Space, submenu exclusion, disabled/read-only inertness, and unchanged source oracles. All temporary registry package identities match the app lock. Locked verification against the published candidate passed all 305 native AGPUI/host/Document/Wikia library tests, 0 skipped, and the combined host/facade Wasm check. The final consumer integration run passed 67/67 tests, including retained replays. Release packaging and both unchanged browser gates passed: viewport geometry and pointer/keyboard/clipboard/sidebar interactions, including actual two-window Loro convergence, with no browser or unexpected network errors. These browser gates use their declared static empty-workspace fixture.
  • Current-head series CI, native CI and doctests: all three passed at the current head. The preceding sidebar source passed its locked Wasm component check and all three CI workflows.
  • Preceding 361d1cc0 native CI passed on Linux, macOS and Windows. The consumer also passed actual browser/canonical-document selected-replacement diagnostics at that input source; those results do not validate the new sidebar hooks.

Review is required before merging this draft. These shared primitives contain no Theorem document or reducer state.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e211d154-b88d-417a-9ce0-fce6312236a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Travis-Gilbert Travis-Gilbert changed the title Align the Kit with the published GPUI Web IME repair Complete GPUI Web focus and input configuration integration Sep 5, 2026
@Travis-Gilbert Travis-Gilbert changed the title Complete GPUI Web focus and input configuration integration Complete platform input configuration and authored Textarea presentation Sep 5, 2026
@Travis-Gilbert Travis-Gilbert changed the title Complete platform input configuration and authored Textarea presentation Complete input presentation and retained sidebar integration Sep 5, 2026
@Travis-Gilbert
Travis-Gilbert marked this pull request as ready for review September 5, 2026 19:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T19:47:46.428885Z d03df3f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d03df3fbd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +131 to +134
id: format!(
"link-{}-{:?}-{link_ix}-{part_ix}",
self.link_source_offset, self.id
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use layout-independent IDs for link fragments

When link_with is used in an InlineFlow, self.id comes from elements.len() in inline_flow.rs, so resizing can renumber a later link whenever preceding text wraps into a different number of positioned fragments. Embedding that transient value in the advertised stable LinkFragment.id also changes the associated retained focus state, causing a focused decorated link to lose keyboard focus during reflow. Derive the fragment/global identity from a stable item or document offset instead of the rendered-fragment ordinal.

Useful? React with 👍 / 👎.

@Travis-Gilbert
Travis-Gilbert merged commit 204d0fc into Codex/gpui-kit-0.6-settings Sep 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant