chore(test): stop the test environment from hiding compiler warnings - #18
Conversation
`--warnings-as-errors` never reaches test files, so warnings there accumulate unchecked and drown out new ones. One of them was pointing at genuinely unreachable code, and the two manual scripts were `.exs`, so nothing ever compiled them. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview Production code: Drops the unreachable Tests & support: Adds explicit Reviewed by Cursor Bugbot for commit 6212b8c. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
💤 Files with no reviewable changes (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe changes remove Dialyzer configuration, tighten pagination and test patterns, move migration fixtures into shared support, replace a manual subscription script, and add reusable long-running subscription support. ChangesEventStore maintenance and test support
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Merge Risk: ⚪ Minimal · up to The changes are mergeable based on the available evidence; no actionable regression remains identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each event in line Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ba87b8. Configure here.
The test event store serializes with `Jason`, so the event struct has to derive the encoder or the first append raises. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
1 participant
mix compile --warnings-as-errorsonly covers the current project in dev, so warnings raised while compiling test files never fail CI. Nine of them had accumulated, and that noise is exactly what hides the next real one.pagination_metadata/1had a catch-all clause that nothing could ever reach, since the only call site always passes a keyword list.dynamic()for bindings that come out ofEnum.mapor list destructuring, so the struct updates that follow cannot be checked. Matching the struct at the binding restores that..dialyzer_ignore.exshad been dead since the postgrex bump and was reported asUnnecessary Skips: 2on every run.test/manual/held two.exsscripts, so nothing ever compiled them.long_running_subscription.exshad rotted into calling functions that only exist insideEventStore.__using__and would have raised on its first subscribe. As compiled modules undertest/support/they are covered by the build.