Skip to content

fix(create-post): guard DMs and ignore source notification failures - #1

Closed
Twest2 wants to merge 1 commit into
masterfrom
fix/create-post-regressions
Closed

fix(create-post): guard DMs and ignore source notification failures#1
Twest2 wants to merge 1 commit into
masterfrom
fix/create-post-regressions

Conversation

@Twest2

@Twest2 Twest2 commented Apr 21, 2026

Copy link
Copy Markdown
Owner

What this changes

This tightens up the post-move flow in src/cogs/create_post.py:

  • skips DM and group DM messages before the support-move logic runs
  • makes the message sent back to the source channel optional, so a permissions issue there does not break the move after the support thread is already created

Why

The previous behavior had two edge cases needing to be addressed:

  • a bot mention in a DM could reach the support-move branch and crash when the code tried to read guild roles
  • if the bot could not send a follow-up message in the original channel, the move could fail partway through even though the new support thread had already been created

Validation

  • python3 -m compileall -q src
  • git diff --check

@Twest2

Twest2 commented Apr 21, 2026

Copy link
Copy Markdown
Owner Author

@copilot review

Copilot AI commented Apr 21, 2026

Copy link
Copy Markdown

@copilot review

Reviewed the PR changes in fed609b and re-validated the branch. Current workflow run is still in progress with no failed jobs so far, and local validation (python3 -m compileall -q src, git diff --check) passes. No additional code changes were needed from this review pass.

@Twest2 Twest2 closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants