Multiple fixes for broken master by line0 · Pull Request #26 · TypesettingTools/DependencyControl

line0 · 2026-05-23T19:05:03Z

This PR fixes several issues, largely caused by the incomplete refactoring some 10 years ago:

SemanticVersioning: this class was missing entirely and has been ported over from the sqlite branch
ModuleLoader: Fixed a regression where __depCtrlInit hooks were called again on - already-initialized modules, causing errors in modules that mutate their exported state on - first call (e.g., BadMutex).,
UpdateFeed: Fixed a regression where legacy boolean true/false script type arguments were - no longer accepted after the ScriptType enum migration.,
UpdateFeed: Fixed a regression where DownloadManager was instantiated too late, causing the - update process to fail.
Common: The capitalize() function no longer uses unsupported string indexing and now works - for the first time ever. Before the refactor, this was previously masked by it not actually - being called anywhere.
Updater: Fixed a potential issue where a multi-assignment statement could corrupt record - fields after an unsuccessful update.

Additionally, i have added a unit test suite for DepCtrl (only 1 tiny test for now) and made all files use LF + EOF Newline to ensure consistent file hashes.

Copilot

Pull request overview

This PR aims to restore a working “master” by reintroducing missing version-handling functionality, fixing several regressions in module loading and update/feed handling, and adding initial unit-test and line-ending consistency infrastructure.

Changes:

Added SemanticVersioning and migrated version parsing/formatting to use it across updater/feed paths.
Fixed/adjusted updater + module-loader behaviors related to initialization and update flows, and added a minimal DepCtrl unit test.
Updated the project update feed metadata, bumped versions, and enforced LF + final newline consistency.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
modules/DependencyControl/Updater.moon	Migrates updater version handling to `SemanticVersioning` and adjusts update logging/changelog display.
modules/DependencyControl/UpdateFeed.moon	Adds legacy scriptType compatibility + new invalid scriptType messaging; moves `DownloadManager` init earlier.
modules/DependencyControl/UnitTestSuite.moon	No functional change (newline normalization).
modules/DependencyControl/Tests.moon	Adds a first unit test for `Common.terms.capitalize`.
modules/DependencyControl/SemanticVersioning.moon	Introduces semantic version parsing/formatting/comparison utilities.
modules/DependencyControl/Record.moon	Switches record version parsing to `SemanticVersioning` and adds compatibility helpers.
modules/DependencyControl/ModuleLoader.moon	Updates init-hook guard logic and switches version formatting/parsing to `SemanticVersioning`.
modules/DependencyControl/FileOps.moon	No functional change (newline normalization).
modules/DependencyControl/ConfigHandler.moon	No functional change (newline normalization).
modules/DependencyControl/Common.moon	Fixes `capitalize()` implementation to avoid unsupported string indexing.
modules/DependencyControl.moon	Bumps DepCtrl version, exposes `SemanticVersioning`, and adds a Moonscript minimum-version guard.
macros/l0.DependencyControl.Toolbox.moon	Bumps toolbox version; updates version formatting and script-type handling; registers DepCtrl test suite.
DependencyControl.json	Updates feed versions/hashes and adds new files (including tests) to the module feed.
.vscode/settings.json	Enforces final newline on save in VS Code.
.gitattributes	Enforces LF line endings in git.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 12 out of 15 changed files in this pull request and generated 5 comments.

…alized modules

… function

Copilot

Pull request overview

Copilot reviewed 12 out of 15 changed files in this pull request and generated 5 comments.

+        maxVer = SemanticVersioning\toNumber @version
+        minVer = SemanticVersioning\toNumber minVer

        changelog = {}
        for ver, entry in pairs @changelog
-            ver = DependencyControl\parseVersion ver
-            verStr = DependencyControl\getVersionString ver
+            ver = SemanticVersioning\toNumber ver
+            verStr = SemanticVersioning\toString ver
            if ver >= minVer and ver <= maxVer


number segments over 255 and non-dot separate values

…r string is passed

…is virtual

nothing inside DepCtrl is supplying this parameter, so the only effect this bug would have had, is removing the default guard against modules trying to load themselves

- assert now passes through all varargs on success (allows chaining) - new assertNotNil method - fails only on nil, unlike assert which also fails on false - dump/dumpToString methods accept a maxDepth to cap recursive table output - new static Logger.describeType method - returns Lua type name but renders MoonScript class instances as "ClassName object" - fix: guard log/format calls against non-string message templates

… message Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…deprecated

…ra lists

…ch mode and block reason

… macros

Add FeedCache, a URL-keyed on-disk store of timestamped feed snapshots with a freshness window, trimming, and stale-offline fallback. UpdateFeed serves fresh snapshots without the network, persists each fetch, and falls back to a stale copy when offline; UpdateTask reuses it and refuses blocked/never feeds. Add a "prompt" option to fetchUntrustedFeeds: FeedTrust gains a fetch-decision gate and session prompter, and the crawl asks before following untrusted feeds. Toolbox: shared feed-inventory build, a "Fetched" age column, an untrusted-feed prompt, and label-map dispatch. Drops the dumpFeeds config. refactor: validate

`@writeConfig if …` compiled to `return self.writeConfig` — a field access, not a call (missing `!`), so a freshly installed or changed record never wrote itself to the config file. Config-driven tooling (FeedInventory/Toolbox) then couldn't see manually installed scripts and version bumps never synced. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@deprecated

…thods They were assigned as class-body fields (@getVersionNumber = SemanticVersioning. toNumber), so `rec\getVersionNumber` — the documented <=0.6.x API — resolved to nil (class fields aren't visible through __base), and toString bound that way would also fail its internal @toNumber call. Restore them as instance methods that default to the record's version and delegate to SemanticVersioning, marked @deprecated. Silent narrowing of a public API is a breaking change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

… on load setDefaults recursed into the copy-on-write proxies it built over the defaults tree. Under the runtime's LUA52COMPAT `__pairs` (which the proxies define), that descent iterated a section's real default keys and, for each table-valued one, fired the proxy's write-through __newindex — deep-copying the defaults over the user's live hive. On every global config load this silently wiped the user's extraFeeds/trustedFeeds/blockedFeeds and reset fetchUntrustedFeeds to `always` (a security regression), persisted on the next save. Only `feeds` was hit, as the only section with table-valued defaults, so it surfaced in 0.7.0. Wrap only top-level sections (no descent): a present section is served per-key by the mergeSection fallthrough via @config, and an absent section keeps its first-write copy-on-write. Drop the now-unreachable nested parent-walk. Includes the per-key mergeSection fallthrough that was in progress in the tree, plus a regression test proven to fail on the old recursion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix: add missing SemanticVersioning module

cd03290

line0 requested a review from Copilot May 23, 2026 19:05

Copilot started reviewing on behalf of line0 May 23, 2026 19:05 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

line0 force-pushed the add-missing-semver-module branch 2 times, most recently from 7f7ad69 to 9fee44a Compare May 23, 2026 22:10

line0 requested a review from Copilot May 23, 2026 22:10

Copilot started reviewing on behalf of line0 May 23, 2026 22:11 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

line0 added 8 commits May 24, 2026 00:22

fix: broken script type handling in update feeds

f147a45

fix: module loader running depctrl initializer hooks on already initi…

bf66595

…alized modules

fix: update failing due to unsupported string index in capitalization…

f2e1fa8

… function

test: add first test

977f37a

ci: enforce LF + EOF newline for consistent hash calculation

75b6c43

build: bump version; update feed

7f2530a

fix: typo in ModuleLoader breaking optional module presence checks

ff8495a

refactor: tighten version number validation in updater

d0cbeee

line0 force-pushed the add-missing-semver-module branch from 9fee44a to ad4a5ec Compare May 23, 2026 22:46

line0 requested a review from Copilot May 23, 2026 22:49

Copilot started reviewing on behalf of line0 May 23, 2026 22:49 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

line0 added 4 commits May 24, 2026 00:58

fix: broken version number display in version errors

d16fd64

fix: typos

167d427

fix: semver parsers allowing invalid values

a1fc3f8

number segments over 255 and non-dot separate values

fix: semantic version toString roundtrip exception when invalid semve…

5bc3f45

…r string is passed

line0 force-pushed the add-missing-semver-module branch from ad4a5ec to 5bc3f45 Compare May 23, 2026 23:14

line0 added 4 commits May 24, 2026 08:14

fix: update errors missing information about whether or not a record …

c08a79c

…is virtual

fix: broken skip lists in module loader

80ead7c

nothing inside DepCtrl is supplying this parameter, so the only effect this bug would have had, is removing the default guard against modules trying to load themselves

fix: nil dereference crash in feed template variable expansion

5a582f0

line0 and others added 29 commits July 9, 2026 00:38

refactor: miscellaneous cleanup

9744e91

fix(tests): honor assertContains case-insensitivity and emit a proper…

3d2b2cc

… message Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(tests): don't abort the whole run on a test-class setup failure

4e8118d

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(tests): correct assertNegative failure message

5359447

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(updater): clean up the temp download dir after install

cd84bf0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(fileops): don't report mkdir success when creation failed

f1cf8c4

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(logger): warm up the RNG after seeding

119fdb8

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(logger): fill the progress bar incrementally

785cbba

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

refactor: make private method consistent across the codebase

3863105

refactor(Updater): improve test coverage

66404ed

refactor(Updater): enum for update status codes

407860a

test(FileLock,NamedSemaphore): initial coverage

d880534

fix(ConfigView): deprecation notices on methods that aren't actually …

e08e40b

…deprecated

refactor: centralize feed trust logic in a separate class

20b842a

feat(FeedTrust): methods for removing feed from trusted, blocked, ext…

37ffe18

…ra lists

refactor(FeedTrust): make block list entries an object; add exact mat…

45fcecf

…ch mode and block reason

feat: add Host class, DNS resolver binding and private host checks

72c4ba4

feat(Updater): block feed/package downloads to private hosts (SSRF)

482436e

fix: depctrl CLI using wrong config file name

079b57b

fix(UpdateFeed): deployment didn't consider delete flag on files

6e3b239

feat(Common): method to check if running headlessly/in CLI

df8b052

refactor(Record): automation script unit tests receive the registered…

140b0ec

… macros

fix: feed JSON schema missing the object form for file base templates

a19bc0e

feat(Toolbox): feed management macro/UI

d0b90b7

test(Toolbox): initial test plumbing for toolbox

30a8aed

line0 force-pushed the add-missing-semver-module branch from 5731374 to cceac44 Compare July 8, 2026 22:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Multiple fixes for broken master#26

Multiple fixes for broken master#26
line0 wants to merge 93 commits into
masterfrom
add-missing-semver-module

line0 commented May 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

line0 commented May 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants