Repository navigation
Conversation
…he stack Three code-simplifier lenses over #768's diff returned 41 findings. Only the behaviour-preserving ones are applied here; everything that would change what the code does is filed instead. Guards that were vacuous, each demonstrated before the fix: * C11 greps a whole card for `StructuredOutput` to prove the body documents the dual-channel return. #763 put that literal into the `tools:` frontmatter of all eight cards, so the frontmatter satisfied it. Stripping the stanza from all eight bodies still passed; now scoped to `## Output` and it reds. * model-routing keyed "declares tools:" on bare key presence, so a key with an empty value counted as a declaration. Emptying one on a live card left the suite at PASS (383 checks) - the exact state #749 exists to red on. Now matches testers-agent-contract's semantics. * ci-shard-diagnose transcribed the harness's membership rule instead of running it. On a plan naming a fixture no invocation offers it reported `MATCH match=12 miss=0` for a shard that reds 11/12. It now carves the job's own run_one out of the live workflow and executes it. * The premerge Constants cap had a name-grep where its two siblings had value locks; it passed at any value. Five mutations now red it. * The unpinned sort/comm detector's narrow twin, plus a bare-terminator mutant row so the widening is itself tested. Prose that contradicted the code it documents. `_growth_ratio` excludes carried rows from both sides and `_growth_round_counts` adds a third eligibility term, but five surfaces still described the pre-narrowing behaviour. Executed against one document with 1 reviewer blocker + 2 carried rows, the prose denominator gives 3 and the code gives 1 - 0.33 vs 1.00, straddling the 0.50 ceiling, i.e. the two copies disagreed about whether the loop stops. SKILL.md, commands/premerge.md and common-mistakes.md corrected; RFC 0021 gets a new A6 amendment rather than an edit, because A5 was accurate when it landed and the narrowings came after it. Also: the fix-commit push now captures git's stderr the way the five SKILL.md fences do (driven against a hostile pre-receive hook), an unreachable fallback deleted after 50 executions with a live anti-vacuity control, the S10 loop re-runs its extractor 3 times instead of 17, and several comments that named dead consumers now name the live ones. Verified: 20 suites green, all at or above baseline. Artifact bytes unchanged where it matters - the premerge-findings refactor was diffed end to end and all 17 run artifacts plus both streams are byte-identical to HEAD's copy.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 24, 2026
TheFJK
merged commit Aug 24, 2026
f3523cc
into
chore/stack-20260824-094351-aa3e54cd6c37b8e8
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #768. The base is the stack branch, so this diff is polish only.
Ran the
/premergePhase 4 three-lens pass (Reuse,Quality,Efficiency) as a standalone branch, because #768 stopped onSTOP_EXHAUSTEDand Phase 4 is gated behind a green clean gate — polishing a stack with live blockers buries them in refactor noise.41 findings. Only the behaviour-preserving ones are applied here. Everything that would change what the code does is filed instead (see below).
Five guards that were vacuous — each demonstrated, not argued
C11dual-channel stanzaStructuredOutputfrom all eight card bodies still passed — #763 had put that literal into thetools:frontmatter, which satisfied the whole-file grep#749tools-declarationtools:value left the suite atPASS (383 checks)— the exact state the guard exists to red onci-shard-diagnose dumpMATCH match=12 miss=0— a clean bill of health — for a shard that reds 11/12PREMERGE_MAX_BLOCKED_ONlocksort/commtwinsort)and end-of-line invocations invisible; landed with a bare-terminator mutant so the widening is itself testedProse that contradicted the code it documents
_growth_ratioexcludes carried rows from both sides and_growth_round_countsrequires a third eligibility term (blockers >= previous_blockers). Five surfaces still described the pre-narrowing behaviour.Executed against one document with 1 reviewer blocker + 2 carried rows: the prose denominator gives 3, the code gives 1 —
0.33vs1.00, straddlingCONVERGE_GROWTH_CEILING(0.50). The two copies disagreed about whether the loop stops.SKILL.md,commands/premerge.mdandreferences/common-mistakes.mdcorrected. RFC 0021 gets a newA6amendment rather than an edit — git chronology confirms A5 was accurate when it landed (a83deaed), and the narrowings came after it in9a7bb510/b1d5ef15/1b5e00cf. Editing A5 would erase the record of a decision that was correct when made.Also
SKILL.mdfences do — driven against a real bare remote with a hostile 17-line pre-receive hookdump(measured: zero plan bytes under that condition) topacker-bytes(the only verb whose output flips), and quoted — on this repo's spaced path the old hint printedbash: /Volumes/FJK: No such file or directoryDeliberately not applied
Behaviour-changing, so filed rather than polished: the
workflow.jsunquoted rate-state directory, closing thegoal-state.shfail-open, thereview-consolidate.shnon-ASCII encoding mismatch, agent prompt-text consolidation, and thepremerge-findings.test.shjq scaffolding swap (~2.8s of 12.55s, but the assertions compare Python repr spellings).Two agents declined work rather than half-do it: the
goal.test.shextractor move is cross-file, and importingcode_fixer_contract.beneathwould turn a stdlib-only module into a 3-module chain and convert a contractedexit 74into an import traceback.Verification
20 suites green, all at or above baseline:
premerge261,premerge-findings208,review-pr471,docs-accuracy309,ci-shard52,ci-wiring30,epipe-guard93,findings-to-issues202,review-pr-consolidate86,vendor-provenance63, plus 10 more.The
premerge-findings.pyrefactor was diffed end to end against HEAD's copy through the full pipeline — all 17 run artifacts and both streams byte-identical, plus a 144-pair differential with zero disagreements.