Repository navigation
refactor(instructions): make CLAUDE.md the project rule file, drop AGENTS.md (v0.56.1) - #787
Merged
Merged
Conversation
…ENTS.md AGENTS.md is the Codex convention. This repo does not use Codex, and the file reached Claude Code only because a one-line CLAUDE.md imported it (#748) — so the rules an agent actually obeys lived in a file named for a tool that never reads this repo. The content moves verbatim into CLAUDE.md: same bump-version-everywhere mandate, same three-lane table, same six surfaces, same rationale. Only the header changed (it inherited from ~/.codex/AGENTS.md; it now inherits from ~/.claude/CLAUDE.md). Nine this-repo citations retargeted: bump-version.sh, review-consolidate.sh, the premerge SKILL (x2), RFC 0021, docs/testing.md, _lib_assert_structural.sh, post-impl-review/references/contracts.md, and .gitignore's comment describing an import that no longer exists. tests/docs-accuracy.test.sh moved with it — its T12 block FATALs when the rule document is unreadable and pins fourteen assertions inside the version section, so it was the one suite the rename actually broke. DELIBERATELY UNCHANGED: the 62 references that are the plugin reading a TARGET repo's convention files. convention-compliance reviews a change against the project's own written rules; research-constraints reads <working_dir>/AGENTS.md; review-fleet-args.sh collects `-name AGENTS.md -o -name CLAUDE.md -o -name .editorconfig`. Deleting those would remove a feature from every repo UberDev is installed into — a different change from this repo not needing the file. Verified those suites pass untouched: convention-citation 60, review-pr-workflow 386, solve-fleet-workflow 586, child-wait, prkit-verify 49. Verified: 16 suites green — docs-accuracy 309, premerge 261, premerge-findings 208, review-pr 471, solve-fleet-workflow 586, review-pr-workflow 386, review-pr-consolidate 86, convention-citation 60, ci-wiring 30, epipe-guard 93, skill-size 49, vendor-provenance 63, prkit-verify 49, plus goal, solve-claim and child-wait.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.mdis the Codex convention. This repo does not use Codex, and the file reached Claude Code only because a one-lineCLAUDE.mdimported it (#748) — so the rules an agent actually obeys lived in a file named for a tool that never reads this repo.What moved
The content is verbatim: same bump-version-everywhere mandate, same three-lane table, same six surfaces, same rationale. The only edit is the header — it inherited from
~/.codex/AGENTS.md, it now inherits from~/.claude/CLAUDE.md.Nine this-repo citations retargeted:
lib/bump-version.shlib/review-consolidate.shskills/premerge-pipeline/SKILL.md×2docs/rfc/0021docs/testing.mdtests/_lib_assert_structural.shpost-impl-review/references/contracts.md.gitignoreThe one suite that actually broke
tests/docs-accuracy.test.sh— its T12 blockFATALs when the rule document is unreadable and pins fourteen assertions inside the version section, so it moved with the file. Everything else passed untouched, which is what confirmed the rest of the references aren't about this repo.Deliberately unchanged — 62 references
These are the plugin reading a target repo's convention files, not this repo's:
convention-compliancereviews a change against the project's own written rulesresearch-constraintsreads<working_dir>/AGENTS.mdreview-fleet-args.shcollects-name AGENTS.md -o -name CLAUDE.md -o -name .editorconfigtests/convention-citation.test.sh(28 refs) verifies agents quote those rules correctlyDeleting them would remove a feature from every repo UberDev is installed into — a different change from this repo not needing the file itself. Verified they pass untouched:
convention-citation60,review-pr-workflow386,solve-fleet-workflow586,child-wait,prkit-verify49.Verification
16 suites green:
docs-accuracy309,premerge261,premerge-findings208,review-pr471,solve-fleet-workflow586,review-pr-workflow386,review-pr-consolidate86,convention-citation60,ci-wiring30,epipe-guard93,skill-size49,vendor-provenance63,prkit-verify49, plusgoal,solve-claim,child-wait.Version bumped to 0.56.1 per the rule this PR moves — patch, since no behaviour changes.