feat(apollo-vertex): support external directory groups in membership gate - #1235
frankkluijtmans wants to merge 2 commits into
Conversation
|
Apollo Coded App preview deployments are ready.
|
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The authorization-critical behavior lacks completed manual validation against an external-group tenant.
Review effort: Balanced
Findings: None
What changed in this PR
Adds external directory group support to Apollo Vertex’s shell membership gate.
Changes:
- Checks local and external group membership in parallel.
- Adds external fallback handling to
useGroupId. - Updates dependency metadata, type declarations, and documentation.
| File | Description |
|---|---|
apps/apollo-vertex/types/optional-deps.d.ts |
Declares the external membership API. |
apps/apollo-vertex/registry/shell/use-is-group-member.ts |
Checks local and external memberships. |
apps/apollo-vertex/registry/shell/use-group-id.ts |
Returns an external group fallback. |
apps/apollo-vertex/registry/shell/group-membership-guard.tsx |
Accepts external group names. |
apps/apollo-vertex/registry.json |
Requires vs-core 4.4.0. |
apps/apollo-vertex/app/patterns/shell/page.mdx |
Documents external group usage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dependency License Review
License distribution
Excluded packages
|
📊 Coverage + size by packagePer-package bundle size on this PR (no JS/TS source changes detected under
"Coverage" is each package's own |
Storybook visual diff✅ No stories are affected by this PR's changes; nothing to compare. Logs Updated (PT): Oct 01, 2026, 12:35:05 AM |
16039df to
05ae08f
Compare
Adds support for external directory groups (e.g. Entra ID) to the shell's group membership gate. The local Group API doesn't return these groups, so users who only get access through one were denied. The check uses
checkExternalGroupMembershipfrom@uipath/vs-core4.4.0 (https://github.com/UiPath/vertical-solutions/pull/289). This backports the fix made in the fins qaqc and loan-setup webapps. This fix was verified in a test environment with an Entra ID group.