Modal component: Add Code and Code w/ Text stories to Apollo Wind - #1237
Conversation
|
Apollo Coded App preview deployments are ready.
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The story additions and helper extraction are consistent, scoped, and preserve existing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds two Monaco-based modal stories and centralizes shared editor utilities without changing dialog runtime behavior.
Changes:
- Adds expandable Code and Code w/ Text modal stories.
- Extracts Monaco themes, samples, and helpers into a shared module.
- Reorders modal stories to match the requested sidebar sequence.
| File | Description |
|---|---|
dialog.stories.tsx |
Adds and orders the new modal examples. |
code-editors.stories.tsx |
Uses extracted Monaco helpers. |
code-editors.shared.tsx |
Centralizes Monaco configuration and adds JSON support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dependency License Review
License distribution
Excluded packages
|
Storybook visual diffBaseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs Updated (PT): Sep 30, 2026, 01:07:44 PM |
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
030891e to
529d114
Compare
Add two Modal stories that open a Monaco editor in a default-sized modal and expand into the takeover variant. Collapsing from the takeover header returns to the default modal, and edits persist across the switch. - Code: header with Run action, styled after the Code Editors Layout Pattern - Code w/ Text: title, description, labeled JSON Variables field, helper text and Cancel/Run footer (Run Single Step pattern) Extract the Monaco demo helpers (theme registry, samples, LiveMonacoEditor, theme sync hook) into code-editors.shared.tsx so both story files share one TypeScript-defaults ref count. LiveMonacoEditor gains an optional language prop for JSON. Reorder the Modal sidebar: Basic, Complex, Link, Delete, Code, Code w/ Text, Takeover, then the remaining stories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
529d114 to
e5885fc
Compare

Summary
Adds two new stories to the Modal component page in Apollo Wind (Components › Overlays › Modal) and reorganizes the sidebar menu order.
What changed
Two new pages
Both open as a standard modal and can expand into a Takeover. Collapsing returns to the standard modal, and edits are kept across the switch.
Reorganized menu order
Basic, Complex, Link, Delete, Code, Code w/ Text, Takeover w/ Sidebar, Takeover no Sidebar, No Button, Scrollable Content, Sticky Footer.
Notes for reviewers
code-editors.shared.tsx) so the Modal and Code Editors pages use the same editor. No visual change to the Code Editors pages.dialog.tsx).Test plan
🤖 Generated with Claude Code