Skip to content

Modal component: Add Code and Code w/ Text stories to Apollo Wind - #1237

Merged
dbacomputer merged 1 commit into
mainfrom
modal-w-code
Oct 1, 2026
Merged

dbacomputer merged 1 commit into
mainfrom
modal-w-code

Conversation

@dbacomputer

@dbacomputer dbacomputer commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator
Screenshot 2026-09-30 at 12 38 39 PM Screenshot 2026-09-30 at 12 38 47 PM

Summary

Adds two new stories to the Modal component page in Apollo Wind (Components › Overlays › Modal) and reorganizes the sidebar menu order.

What changed

Two new pages

  • Code: a code editor modal with an "Expression" header, Run action, and expand/close controls. Styling matches the Code Editors Layout Pattern story.
  • Code w/ Text: a "Run Single Step" style modal with a title, description, a JSON Variables editor, helper text, and Cancel/Run actions.

Both open as a standard modal and can expand into a Takeover. Collapsing returns to the standard modal, and edits are kept across the switch.

Reorganized menu order

Basic, Complex, Link, Delete, Code, Code w/ Text, Takeover w/ Sidebar, Takeover no Sidebar, No Button, Scrollable Content, Sticky Footer.

Notes for reviewers

  • The code editor helpers were moved into a shared file (code-editors.shared.tsx) so the Modal and Code Editors pages use the same editor. No visual change to the Code Editors pages.
  • No changes to the Modal component itself (dialog.tsx).

Test plan

  • Lint and type checks pass
  • Modal unit tests pass
  • Verified in Storybook: open, edit, expand, collapse, close, reopen
  • Code Editors › Layout Pattern still renders

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings September 29, 2026 16:05
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Apollo Coded App preview deployments are ready.

Project Status Preview Updated (PT)
apollo-design Ready Preview · Logs Sep 30, 2026, 01:04:31 PM
apollo-docs Ready Preview · Logs Sep 30, 2026, 01:04:31 PM
apollo-landing Ready Preview · Logs Sep 30, 2026, 01:04:31 PM
apollo-vertex Ready Preview · Logs Sep 30, 2026, 01:04:31 PM

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The story additions and helper extraction are consistent, scoped, and preserve existing behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Adds two Monaco-based modal stories and centralizes shared editor utilities without changing dialog runtime behavior.

Changes:

  • Adds expandable Code and Code w/ Text modal stories.
  • Extracts Monaco themes, samples, and helpers into a shared module.
  • Reorders modal stories to match the requested sidebar sequence.
File Description
dialog.stories.tsx Adds and orders the new modal examples.
code-editors.stories.tsx Uses extracted Monaco helpers.
code-editors.shared.tsx Centralizes Monaco configuration and adds JSON support.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • ✅ 1937 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1708
ISC 88
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.3 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Storybook visual diff

⚠️ Visual changes detected: 3 changed, 4 added (of 40 compared, 33 unchanged). View report

Baseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs

Updated (PT): Sep 30, 2026, 01:07:44 PM

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core — — 42.01 MB 50.16 MB +8.0 KB
@uipath/apollo-react 48.3% — 7.78 MB 30.29 MB +223.5 KB
@uipath/apollo-ui-icons — — 2.86 MB 6.96 MB +6.0 KB
@uipath/apollo-wind 70.0% 0.0% (0/44) 552.8 KB 3.36 MB +105.2 KB
@uipath/ap-chat 85.8% — 43.90 MB 56.64 MB −27.1 KB

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@dbacomputer dbacomputer changed the title docs(apollo-wind): add Code and Code w/ Text modal stories Modal component: Add Code and Code w/ Text stories to Apollo Wind Sep 30, 2026
@dbacomputer
dbacomputer marked this pull request as ready for review September 30, 2026 19:46
Copilot AI balanced review requested due to automatic review settings September 30, 2026 19:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The expanded Code w/ Text dialog drops its accessible description.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread packages/apollo-wind/src/components/ui/dialog.stories.tsx Outdated
Add two Modal stories that open a Monaco editor in a default-sized modal
and expand into the takeover variant. Collapsing from the takeover header
returns to the default modal, and edits persist across the switch.

- Code: header with Run action, styled after the Code Editors Layout Pattern
- Code w/ Text: title, description, labeled JSON Variables field, helper
  text and Cancel/Run footer (Run Single Step pattern)

Extract the Monaco demo helpers (theme registry, samples, LiveMonacoEditor,
theme sync hook) into code-editors.shared.tsx so both story files share one
TypeScript-defaults ref count. LiveMonacoEditor gains an optional language
prop for JSON.

Reorder the Modal sidebar: Basic, Complex, Link, Delete, Code,
Code w/ Text, Takeover, then the remaining stories.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The stories, state handling, accessibility associations, and shared helper extraction are consistent and complete.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@dbacomputer
dbacomputer enabled auto-merge (rebase) September 30, 2026 19:58
@dbacomputer
dbacomputer merged commit 3b5b029 into main Oct 1, 2026
45 checks passed
@dbacomputer
dbacomputer deleted the modal-w-code branch October 1, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-wind size:XXL 1,000+ changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants